Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7, 1.7.1, 1.7.2, 1.8
    • Fix Version/s: 1.9
    • Component/s: Administration
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      34470

      Description

      Before the administration interface moving to formslib, I seem to recall that the setting for maxbytes allowed a dropdown selection of upload sizes, much like the course page. Now the setting is just a text field which requires sizes to be specified in bytes (not the most intuitive thing to do).

      I can't think of a reason as to why this needs to be a text field (particularly when other parts of the interface use the dropdown approach). There also seems to be the (not particularly documented) behaviour that setting this to 0 will use the servers limit.

      I've created a patch to use a dropdown box in order to set the max size, rather than needing to specify in bytes in text format.

        Activity

        Hide
        Dan Poltawski added a comment -

        Martin, is there a reason the maxbytes setting is a text field, or can I go ahead and change it to a selection box?

        Show
        Dan Poltawski added a comment - Martin, is there a reason the maxbytes setting is a text field, or can I go ahead and change it to a selection box?
        Hide
        Petr Škoda added a comment -

        Administration does not use new formslib, it has its own library.

        My +1 for changing it back to the old way in HEAD
        maybe even backporting to 1.8.1 (MD will have to confirm it first)

        We should also deal with existing setting - either by rounding or beeter adding the current value into the list (my +1 for adding)

        Show
        Petr Škoda added a comment - Administration does not use new formslib, it has its own library. My +1 for changing it back to the old way in HEAD maybe even backporting to 1.8.1 (MD will have to confirm it first) We should also deal with existing setting - either by rounding or beeter adding the current value into the list (my +1 for adding)
        Hide
        Dan Poltawski added a comment -

        I've commited this to HEAD. Incorporating petr's suggesiton of adding the current maxbytes setting to the list if available to be selected.

        Show
        Dan Poltawski added a comment - I've commited this to HEAD. Incorporating petr's suggesiton of adding the current maxbytes setting to the list if available to be selected.
        Hide
        Petr Škoda added a comment -

        we are getting very close to 1.9 - backporting to 1.8.x is not a priority IMHO.
        closing now, thanks for the report and the fix in cvs.

        Show
        Petr Škoda added a comment - we are getting very close to 1.9 - backporting to 1.8.x is not a priority IMHO. closing now, thanks for the report and the fix in cvs.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: