Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-9745

Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.8, 1.9
    • Fix Version/s: None
    • Component/s: Forms Library
    • Labels:
      None
    • Database:
      Any
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      please see screenshot. For default font size, the text tend to overlap a little bit but if you enlarge the font size, the overlapping would be really bad

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timhunt Tim Hunt added a comment -

              Jamie, this is a generic forms lib problem, and after a brief look, I can't work out how to solve it, so I am assigning it to you. Sorry.

              Show
              timhunt Tim Hunt added a comment - Jamie, this is a generic forms lib problem, and after a brief look, I can't work out how to solve it, so I am assigning it to you. Sorry.
              Hide
              timhunt Tim Hunt added a comment -

              Sorry, here is more information, the problem is this code at the end of theme/standard/styles_ie6/7.css:

              /*fix for misalignment of text fields in ie */
              form.mform input {
              margin-left: -10px;
              margin-right: 10px;
              }

              form.mform .fcheckbox input {
              margin-left: -3px;
              }

              According to CVS, that code was originally done by you, Jamie, then modified by Marting D.

              Show
              timhunt Tim Hunt added a comment - Sorry, here is more information, the problem is this code at the end of theme/standard/styles_ie6/7.css: /*fix for misalignment of text fields in ie */ form.mform input { margin-left: -10px; margin-right: 10px; } form.mform .fcheckbox input { margin-left: -3px; } According to CVS, that code was originally done by you, Jamie, then modified by Marting D.
              Hide
              jamiesensei Jamie Pratt added a comment -

              Reassigning to Urs. Hope that you can find a nice solution for this issue Urs since you have more of an in depth knowledge of css and the quirks of different browsers handling of css.

              Show
              jamiesensei Jamie Pratt added a comment - Reassigning to Urs. Hope that you can find a nice solution for this issue Urs since you have more of an in depth knowledge of css and the quirks of different browsers handling of css.
              Hide
              urshunkler Urs Hunkler added a comment -

              This seams to be a bigger issue. When I take out the negative left margin all text input fields in that form are not aligned with the other fields. May be we need to change forms lib to add classes to be able to correct this IE misbehavoiur I'll investigate ...

              Show
              urshunkler Urs Hunkler added a comment - This seams to be a bigger issue. When I take out the negative left margin all text input fields in that form are not aligned with the other fields. May be we need to change forms lib to add classes to be able to correct this IE misbehavoiur I'll investigate ...
              Hide
              jamiesensei Jamie Pratt added a comment -

              problem with correct alignment of ie form elements continues. Previous fix for same issue in MDL-7779 also causes problems. Will remove previous fix from standard theme.

              Show
              jamiesensei Jamie Pratt added a comment - problem with correct alignment of ie form elements continues. Previous fix for same issue in MDL-7779 also causes problems. Will remove previous fix from standard theme.
              Hide
              urshunkler Urs Hunkler added a comment -

              Added CSS 2 attributed to fix IE7 and IE specific "expression" JavaScript in CSS properties to fix IE6. If you find still issues please reopen.

              Show
              urshunkler Urs Hunkler added a comment - Added CSS 2 attributed to fix IE7 and IE specific "expression" JavaScript in CSS properties to fix IE6. If you find still issues please reopen.
              Hide
              ryantam Ryan Tam added a comment -

              In IE6, the problem is solved.

              Show
              ryantam Ryan Tam added a comment - In IE6, the problem is solved.
              Hide
              ryantam Ryan Tam added a comment -

              In IE7, the problem appearing at the beginning of texts is fixed but the end it still not fixed.

              Show
              ryantam Ryan Tam added a comment - In IE7, the problem appearing at the beginning of texts is fixed but the end it still not fixed.
              Hide
              dougiamas Martin Dougiamas added a comment -

              I thought I fixed this in MDL-9126 ?

              Show
              dougiamas Martin Dougiamas added a comment - I thought I fixed this in MDL-9126 ?
              Hide
              urshunkler Urs Hunkler added a comment -

              I applied a similar correction to 1.8 as previously to 1.9. (Sorry, I forgot to mention that I appleid the correction only to 1.9)

              Ryan, what do you mean with "... but the end it still not fixed." What end is not fixed? Can you please show an example?

              Show
              urshunkler Urs Hunkler added a comment - I applied a similar correction to 1.8 as previously to 1.9. (Sorry, I forgot to mention that I appleid the correction only to 1.9) Ryan, what do you mean with "... but the end it still not fixed." What end is not fixed? Can you please show an example?
              Hide
              ryantam Ryan Tam added a comment -

              I mean check boxes overlap with the words in front of them which shows in the screen shot, IE7 quiz oversized text overlap not fixed.jpg. I tried that on several browsers and it only happens in IE7 right now.

              Show
              ryantam Ryan Tam added a comment - I mean check boxes overlap with the words in front of them which shows in the screen shot, IE7 quiz oversized text overlap not fixed.jpg. I tried that on several browsers and it only happens in IE7 right now.
              Hide
              urshunkler Urs Hunkler added a comment -

              Ryan, with the lastest Moodle versions 1.8 and 1.9 I don't get overlaping text.

              Which version are you using and which theme?

              Show
              urshunkler Urs Hunkler added a comment - Ryan, with the lastest Moodle versions 1.8 and 1.9 I don't get overlaping text. Which version are you using and which theme?
              Hide
              jenny-gray Jenny Gray added a comment -

              Sorry to re-open this. I'm not seeing overlapping form fields any more, but what i have noticed is that if you switch to text mode rather than wysiwyg mode when you're using the HTML editor, in IE6 only the first character of every line is pushed off the left-hand edge.

              This is caused by the same margin-left: -10px for textarea that's being discussed elsewhere in this issue.

              If you open the html editor in fullscreen mode, it is fine.

              Show
              jenny-gray Jenny Gray added a comment - Sorry to re-open this. I'm not seeing overlapping form fields any more, but what i have noticed is that if you switch to text mode rather than wysiwyg mode when you're using the HTML editor, in IE6 only the first character of every line is pushed off the left-hand edge. This is caused by the same margin-left: -10px for textarea that's being discussed elsewhere in this issue. If you open the html editor in fullscreen mode, it is fine.
              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for reporting this issue.

              We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

              If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

              Michael d;

              lqjjLKA0p6

              Show
              salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
              Hide
              salvetore Michael de Raadt added a comment -

              I'm closing this issue as it has become inactive and does not appear to affect a current supported version. If you are encountering this problem or one similar, please launch a new issue.

              Show
              salvetore Michael de Raadt added a comment - I'm closing this issue as it has become inactive and does not appear to affect a current supported version. If you are encountering this problem or one similar, please launch a new issue.

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: