Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.1
    • Component/s: Groups
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      There are several regressions, unfinished code, roles related problems and also some old bugs in groups implementation.

      I am working on these problems now...

        Gliffy Diagrams

        1. groups_181_2.patch
          89 kB
          Petr Skoda
        2. groups_181.patch
          88 kB
          Petr Skoda

          Issue Links

            Activity

            skodak Petr Skoda created issue -
            Hide
            skodak Petr Skoda added a comment -

            unfinished patch attached

            Show
            skodak Petr Skoda added a comment - unfinished patch attached
            skodak Petr Skoda made changes -
            Field Original Value New Value
            Attachment groups_18.patch [ 11237 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9670 [ MDL-9670 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9769 [ MDL-9769 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9365 [ MDL-9365 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-8914 [ MDL-8914 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9520 [ MDL-9520 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9438 [ MDL-9438 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9127 [ MDL-9127 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9806 [ MDL-9806 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9807 [ MDL-9807 ]
            skodak Petr Skoda made changes -
            Attachment groups_18.patch [ 11237 ]
            skodak Petr Skoda made changes -
            Attachment groups_181.patch [ 11246 ]
            Hide
            skodak Petr Skoda added a comment -

            the patch above is ready for testing

            Show
            skodak Petr Skoda added a comment - the patch above is ready for testing
            Hide
            dougiamas Martin Dougiamas added a comment -

            OK, I'm testing it now. Thanks, Petr!

            Show
            dougiamas Martin Dougiamas added a comment - OK, I'm testing it now. Thanks, Petr!
            Hide
            andreabix Andrea Bicciolo added a comment -

            Thanks Petr. I've patched a production site which makes extensive use of separated groups in chat and databases. Currently all seems working corerctly, we are monitoring the resultes in the next hours.

            Show
            andreabix Andrea Bicciolo added a comment - Thanks Petr. I've patched a production site which makes extensive use of separated groups in chat and databases. Currently all seems working corerctly, we are monitoring the resultes in the next hours.
            skodak Petr Skoda made changes -
            Attachment groups_181_2.patch [ 11248 ]
            Hide
            ray Ray Lawrence added a comment -

            Hi,
            Just updated from anon CVS (UK). Resources still have groups settings (MDL-9365).

            How long will it take for me to be able to check the 181_2.patch via anon CVS?

            Show
            ray Ray Lawrence added a comment - Hi, Just updated from anon CVS (UK). Resources still have groups settings ( MDL-9365 ). How long will it take for me to be able to check the 181_2.patch via anon CVS?
            Hide
            dougiamas Martin Dougiamas added a comment -

            Petr, groups are all looking really good, apart from those few small interface things we talked about in Skype (moving menu to left again, and hiding groupings fully)

            Check it in!

            Thanks for the excellent catch! :-D

            Show
            dougiamas Martin Dougiamas added a comment - Petr, groups are all looking really good, apart from those few small interface things we talked about in Skype (moving menu to left again, and hiding groupings fully) Check it in! Thanks for the excellent catch! :-D
            Hide
            skodak Petr Skoda added a comment -

            committed into cvs, please report any problems
            thanks for testing and reports!

            Show
            skodak Petr Skoda added a comment - committed into cvs, please report any problems thanks for testing and reports!
            skodak Petr Skoda made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            skodak Petr Skoda made changes -
            Link This issue will help resolve MDL-9774 [ MDL-9774 ]
            Hide
            aborrow Anthony Borrow added a comment -

            Petr/MartinD - I may be helpful to update http://docs.moodle.org/en/group/index#Groups_in_Moodle_1.8_onwards and http://docs.moodle.org/en/Groups_FAQ#Groupings so that it is consistent. From what I can tell the plan to implement groupings in 1.8 has been aborted (post release). This does not seem to be a trivial change. If folks were using 1.8 and had groupings defined, have steps been taken to create the enablegroupings record in mdl_config? I did not see any set_config statements so I am assuming not. I am concerned for those who use CVS to update their sites, all of a sudden groupings will no longer be working and I think some type of warning/documentation should exist to clarify what is happening. Thanks for your work and for keeping the Moodle code and documentation top notch. Peace - Anthony

            Show
            aborrow Anthony Borrow added a comment - Petr/MartinD - I may be helpful to update http://docs.moodle.org/en/group/index#Groups_in_Moodle_1.8_onwards and http://docs.moodle.org/en/Groups_FAQ#Groupings so that it is consistent. From what I can tell the plan to implement groupings in 1.8 has been aborted (post release). This does not seem to be a trivial change. If folks were using 1.8 and had groupings defined, have steps been taken to create the enablegroupings record in mdl_config? I did not see any set_config statements so I am assuming not. I am concerned for those who use CVS to update their sites, all of a sudden groupings will no longer be working and I think some type of warning/documentation should exist to clarify what is happening. Thanks for your work and for keeping the Moodle code and documentation top notch. Peace - Anthony
            Hide
            aborrow Anthony Borrow added a comment -

            Petr/MartinD - I have updated the above referenced Docs - please review them to make sure that they are accurate and helpful to other users. Peace - Anthony

            Show
            aborrow Anthony Borrow added a comment - Petr/MartinD - I have updated the above referenced Docs - please review them to make sure that they are accurate and helpful to other users. Peace - Anthony
            Hide
            aborrow Anthony Borrow added a comment -

            Is there a way for me to replace the groups tables in my 1.8 installation and isolate the group upgrade? I'm trying to troubleshoot why there are so many fewer records in mdl_groups_members than there are in mdl_groups_members_temp. Being able to isolate the group upgrade would greatly help in testing things. Any pointers would be appreciated.

            Show
            aborrow Anthony Borrow added a comment - Is there a way for me to replace the groups tables in my 1.8 installation and isolate the group upgrade? I'm trying to troubleshoot why there are so many fewer records in mdl_groups_members than there are in mdl_groups_members_temp. Being able to isolate the group upgrade would greatly help in testing things. Any pointers would be appreciated.
            Hide
            skodak Petr Skoda added a comment -

            I am going to review the docs now.
            The group upgrade is defined in one file only, you can have a look into group/db/upgrade.php function groups_transfer_db()
            looking at the upgrade code it looks to be badly inefficient - it should have been done with SQL instead of loops with php functions

            The problem could be that the script died during upgrade or if one group fails for some reason, the rest is skipped.

            Show
            skodak Petr Skoda added a comment - I am going to review the docs now. The group upgrade is defined in one file only, you can have a look into group/db/upgrade.php function groups_transfer_db() looking at the upgrade code it looks to be badly inefficient - it should have been done with SQL instead of loops with php functions The problem could be that the script died during upgrade or if one group fails for some reason, the rest is skipped.
            dougiamas Martin Dougiamas made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            QA Assignee nobody
            dougiamas Martin Dougiamas made changes -
            Workflow jira [ 20811 ] MDL Workflow [ 56047 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 56047 ] MDL Full Workflow [ 85155 ]
            poltawski Dan Poltawski made changes -
            Link This issue caused a regression MDL-32514 [ MDL-32514 ]
            Subversion JIRA

            Links Hierarchy

             Documentation

            Invalid license: EXPIRED

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jun/07