Moodle
  1. Moodle
  2. MDL-9932

Calendar event restore - does not restore events with same date, description

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.1, 1.9
    • Component/s: Backup
    • Labels:
      None
    • Database:
      Any
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      24528

      Description

      When restoring a calendar event it checks whether the event exists by using the course ID, time, and description fields. If there are two events on the same day, this means that 'description' is the only distinguishing field.

      This caused a minor confusion for me while testing (I had used the description 'x' for two events), but will cause more serious problems if we allow blank descriptions. Blank descriptions can happen particularly if calendar events are imported from another system that does not provide descriptions, so it's mainly an integration issue.

      I am changing it so that the check also includes 'name'. (If you have two events on the same day/time with the same name AND description then... well... that's not really two events, is it? So hopefully that is enough.)

        Activity

        Hide
        Sam Marshall added a comment -

        Fixed and checked into 1.8 and HEAD.

        I had to change it to use get_record_select instead of get_record because it needed four parameters.

        Show
        Sam Marshall added a comment - Fixed and checked into 1.8 and HEAD. I had to change it to use get_record_select instead of get_record because it needed four parameters.

          People

          • Assignee:
            Sam Marshall
            Reporter:
            Sam Marshall
            Tester:
            Nobody
            Participants:
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: