Moodle
  1. Moodle
  2. MDL-9944

Current resource link option for new window not appropriate for files requiring helper applications

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.6.5
    • Fix Version/s: None
    • Component/s: Accessibility, Resource
    • Labels:
      None
    • Environment:
      user browsers IE7, Firefox 2.x
    • Affected Branches:
      MOODLE_16_STABLE
    • Rank (Obsolete):
      3695

      Description

      when clicking a resource link created with new window option, if the resource file is pdf, xls or doc (may apply to others) the popup window is blank and the resource file is opened in its own window.

      this is confusing for users

      when creating a resource there should be a third option for files of type pdf, xls, doc (maybe others too) in which the resource link is a simple url with the attribute rel='external'. this avoids the blank popup appearing.

        Activity

        Hide
        Gary Prosser added a comment -

        I see that rel="external" is not standards compliant and works in FF2 but not IE7.

        Another approach could be to extend the $resourcetype options in function display in resource.class.php to include eg $resourcetype='non_embedded_helper' (for mimetypes such as doc, xls, pdf). In these cases the display function could generate/ trigger a javascript window.location.href method rather than window.open

        Show
        Gary Prosser added a comment - I see that rel="external" is not standards compliant and works in FF2 but not IE7. Another approach could be to extend the $resourcetype options in function display in resource.class.php to include eg $resourcetype='non_embedded_helper' (for mimetypes such as doc, xls, pdf). In these cases the display function could generate/ trigger a javascript window.location.href method rather than window.open

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: