Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Duplicate
    • Component/s: moodle.org
    • Labels:
      None

      Description

      I happened to be checking the validation of moodle.org at:

      http://validator.w3.org/check?uri=http%3A%2F%2Fmoodle.org%2F&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.1

      and noticed the following:

      Validation Output: 1 Error

      1. Error Line 38, Column 4398: document type does not allow element "input" here; missing one of "p", "h1", "h2", "h3", "h4", "h5", "h6", "div", "pre", "address", "fieldset", "ins", "del" start-tag

      ...ine"><input type="submit" value="Go" /></noscript></div></form></div> ...

      I'm not sure why the input type is declared inside the noscript. I looked at /lib/outputrenderers.php ~1175

      Petr seems to have introduced this at:
      http://cvs.moodle.org/moodle/lib/outputrenderers.php?view=diff&r1=1.156&r2=1.157
      in relation to MDL-20204

      I don't see the need for the noscript but I suspect that the validation is complaining because it is not accepting <input> inside of the <noscript> tag. On my server I simply replaced it with:

      $output .= html_writer::empty_tag('input', array('type'=>'submit', 'value'=>get_string('go')));
      // $go = html_writer::empty_tag('input', array('type'=>'submit', 'value'=>get_string('go')));
      // $output .= html_writer::tag('noscript', $go, array('style'=>'inline'));

      and then the page validated fine. Peace - Anthony

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              aborrow Anthony Borrow created issue -
              aborrow Anthony Borrow made changes -
              Field Original Value New Value
              Assignee Helen Foster [ tsala ] Dongsheng Cai [ dongsheng ]
              aborrow Anthony Borrow made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Duplicate [ 3 ]
              QA Assignee aborrow
              aborrow Anthony Borrow made changes -
              Link This issue will be resolved by MDL-24650 [ MDL-24650 ]
              dougiamas Martin Dougiamas made changes -
              Workflow jira [ 39429 ] SITES Full Workflow [ 126317 ]
              dougiamas Martin Dougiamas made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              tsala Helen Foster made changes -
              Workflow SITES Full Workflow [ 126317 ] SITES workflow plus [ 136731 ]

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: