Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-1149

Moodle 2.0 language pack downloads are not recorded in statistics

    Details

      Description

      Reported by Eloy:

      just detected that the downloads @ http://download.moodle.org/langpack/2.0/ are being downloaded directly, without any intermediate .php script.
      we use to put all downloads under the download.php script (or another downloaddirect or so), to get all them accounted @ http://download.moodle.org/stats.php
      just guessing if you could handle that with Jordan to get those 2.0 downloads accounted (it's 1-insert in one table I don't rememeber now, sure Jordan does)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              mudrd8mz David Mudrák added a comment -

              Hi Jordan, can you please help with this? I can modify the links at the generated index page according to your instructions. Thanks in advance.

              Show
              mudrd8mz David Mudrák added a comment - Hi Jordan, can you please help with this? I can modify the links at the generated index page according to your instructions. Thanks in advance.
              Hide
              jtomkinson Jordan Tomkinson added a comment -

              The hyperlinks were incorrect in index.php
              I have fixed them up but if someone/something modifies it they may be lost.
              How is the index.php generated?

              Show
              jtomkinson Jordan Tomkinson added a comment - The hyperlinks were incorrect in index.php I have fixed them up but if someone/something modifies it they may be lost. How is the index.php generated?
              Hide
              mudrd8mz David Mudrák added a comment -

              That is why I asked you for the instructions so I can fix the generator that is part of AMOS. The file is overwritten every hour. Tia

              Show
              mudrd8mz David Mudrák added a comment - That is why I asked you for the instructions so I can fix the generator that is part of AMOS. The file is overwritten every hour. Tia
              Hide
              jtomkinson Jordan Tomkinson added a comment - - edited

              it certainly helps if i read the comments doesnt it!

              so yeah just prefix your links wit http://download.moodle.org/download.php/langpack/2.0/file.name

              Show
              jtomkinson Jordan Tomkinson added a comment - - edited it certainly helps if i read the comments doesnt it! so yeah just prefix your links wit http://download.moodle.org/download.php/langpack/2.0/file.name
              Hide
              mudrd8mz David Mudrák added a comment -

              Links generation fixed by
              https://github.com/mudrd8mz/moodle-local_amos/commit/63d17b9d995152e1c56d9b6e9dd7b447a76c7a0e

              The page regenerated and seems to work. Thanks Jordan and Eloy

              Show
              mudrd8mz David Mudrák added a comment - Links generation fixed by https://github.com/mudrd8mz/moodle-local_amos/commit/63d17b9d995152e1c56d9b6e9dd7b447a76c7a0e The page regenerated and seems to work. Thanks Jordan and Eloy
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Thanks!

              Slightly related with this.... when we download lang packs from within Moodle...are we using direct links? Perhaps it would be interesting to use the 'directdownload.php' script (note I don't remember 100x100 if the exact name is that), that also performs the accounting but doesn't does any redirect (splash page)?

              Just asking for opinions...

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Thanks! Slightly related with this.... when we download lang packs from within Moodle...are we using direct links? Perhaps it would be interesting to use the 'directdownload.php' script (note I don't remember 100x100 if the exact name is that), that also performs the accounting but doesn't does any redirect (splash page)? Just asking for opinions...
              Hide
              jtomkinson Jordan Tomkinson added a comment -

              direct downloads are done by using /download.php/direct/langpack/2.0/file.name/

              Show
              jtomkinson Jordan Tomkinson added a comment - direct downloads are done by using /download.php/direct/langpack/2.0/file.name/
              Hide
              mudrd8mz David Mudrák added a comment -

              Good point Eloy! I just created a clone to track the downloads via component_installer.

              Show
              mudrd8mz David Mudrák added a comment - Good point Eloy! I just created a clone to track the downloads via component_installer.
              Hide
              mudrd8mz David Mudrák added a comment -

              This will be fixed by MDL-25461 - all downloads since 2.1 will be processed via /download.php/direct/...

              Note that I am not going to fix this for 2.0+ intentionally so that we have a well defined start point for the statistics (and also because in 2.1 it is much easier to control the URL as it is defined at a single place).

              Show
              mudrd8mz David Mudrák added a comment - This will be fixed by MDL-25461 - all downloads since 2.1 will be processed via /download.php/direct/... Note that I am not going to fix this for 2.0+ intentionally so that we have a well defined start point for the statistics (and also because in 2.1 it is much easier to control the URL as it is defined at a single place).

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: