Moodle Community Sites
  1. Moodle Community Sites
  2. MDLSITE-1372

Remove 19 from Moodle Docs combined versions URLs and replace 1.9 image

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Component/s: docs.moodle.org
    • Labels:

      Description

      Jordan, can we remove the "1.9" from the theme and the "19" from the URL of the wikis for languages where they have chosen not to follow the english versions?

        Gliffy Diagrams

          Issue Links

            Activity

            Martin Dougiamas created issue -
            Martin Dougiamas made changes -
            Field Original Value New Value
            Assignee Helen Foster [ tsala ] Jordan Tomkinson [ jtomkinson ]
            Hide
            Jordan Tomkinson added a comment -

            removing the 1.9 from the theme is simple and has been done on docstest but removing the URL will require a rewrite of all the htaccess rules currently in place. this requires many hours of testing and i strongly -1 the idea

            Show
            Jordan Tomkinson added a comment - removing the 1.9 from the theme is simple and has been done on docstest but removing the URL will require a rewrite of all the htaccess rules currently in place. this requires many hours of testing and i strongly -1 the idea
            Hide
            Martin Dougiamas added a comment -

            OK, then just the theme is fine for now.

            Show
            Martin Dougiamas added a comment - OK, then just the theme is fine for now.
            Hide
            Jordan Tomkinson added a comment -

            pushed changes for theme to production site

            Show
            Jordan Tomkinson added a comment - pushed changes for theme to production site
            Hide
            Martin Dougiamas added a comment -

            Looks good, thanks

            Show
            Martin Dougiamas added a comment - Looks good, thanks
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Well, it will look ok for you that never access the es, fr, is, eu, hr, pt_br wikis.

            Definitively it does not look ok for me (as an "es" user).

            Just asking if it would be easier to transform the "19" into anything else, say "docs", "pfff", or "yay!" ?

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Well, it will look ok for you that never access the es, fr, is, eu, hr, pt_br wikis. Definitively it does not look ok for me (as an "es" user). Just asking if it would be easier to transform the "19" into anything else, say "docs", "pfff", or "yay!" ? Ciao
            Hide
            Jordan Tomkinson added a comment -

            It would be a lot simpler to replace "19" with some other word than remove it completely.. +1

            Show
            Jordan Tomkinson added a comment - It would be a lot simpler to replace "19" with some other word than remove it completely.. +1
            Hide
            Eloy Lafuente (stronk7) added a comment - - edited

            Yay!

            Anything would be better than 19: docs, multi, unified, md, thinks...

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - - edited Yay! Anything would be better than 19: docs, multi, unified, md, thinks... Ciao
            Hide
            Jordan Tomkinson added a comment -

            bump

            Show
            Jordan Tomkinson added a comment - bump
            Hide
            Jordan Tomkinson added a comment -

            bump for justice

            Show
            Jordan Tomkinson added a comment - bump for justice
            Hide
            Helen Foster added a comment -

            How about replacing 19 with 'wiki' (like wikipedia urls).

            Show
            Helen Foster added a comment - How about replacing 19 with 'wiki' (like wikipedia urls).
            Hide
            Martin Dougiamas added a comment -

            if we make it "wiki" it looks a little weird that the others don't have "wiki".

            Since it's replacing the version, I think the word should refer to the version.

            So I will vote for 'all' as the shortest replacement.

            Show
            Martin Dougiamas added a comment - if we make it "wiki" it looks a little weird that the others don't have "wiki". Since it's replacing the version, I think the word should refer to the version. So I will vote for 'all' as the shortest replacement.
            Hide
            Jordan Tomkinson added a comment -

            Martin would like to remove the version images on unified wikis
            we need to modify the new docs theme to support this

            Show
            Jordan Tomkinson added a comment - Martin would like to remove the version images on unified wikis we need to modify the new docs theme to support this
            Sam Hemelryk made changes -
            Assignee Jordan Tomkinson [ jtomkinson ] Sam Hemelryk [ samhemelryk ]
            Hide
            Martin Dougiamas added a comment -

            Yeah that regressed in the new theme.

            Show
            Martin Dougiamas added a comment - Yeah that regressed in the new theme.
            Hide
            Jordan Tomkinson added a comment -

            changing assignee to Sam H
            after he has modified the theme to support no version images he will reassign back to me and i will change the paths at the same time

            Show
            Jordan Tomkinson added a comment - changing assignee to Sam H after he has modified the theme to support no version images he will reassign back to me and i will change the paths at the same time
            Hide
            Helen Foster added a comment -

            Increasing priority as this issue has been open for several months and the current situation is not nice at all for people making an effort to keep their documentation for combined versions up-to-date.

            How about replacing the 1.9 image with a 'Moodle Docs' image?

            Show
            Helen Foster added a comment - Increasing priority as this issue has been open for several months and the current situation is not nice at all for people making an effort to keep their documentation for combined versions up-to-date. How about replacing the 1.9 image with a 'Moodle Docs' image?
            Helen Foster made changes -
            Summary Look at moving the "unified" wikis (es, fr, is, eu, hr, pt_br) to plain URLs without /19/ Remove 19 from Moodle Docs combined versions URLs and replace 1.9 image
            Priority Minor [ 4 ] Critical [ 2 ]
            Labels triaged
            Dan Poltawski made changes -
            Assignee Sam Hemelryk [ samhemelryk ] Dan Poltawski [ poltawski ]
            Hide
            Dan Poltawski added a comment -

            I've got a working implementation of the combined wikis being in the all namespace on there test site here:

            http://docstest.moodle.local/all/es/Página_Principal

            I think thats working exactly as we want it, but the lack of the combined wiki image is because there is a broken image reference - mediawiki doesn't like loosing its logo!

            Show
            Dan Poltawski added a comment - I've got a working implementation of the combined wikis being in the all namespace on there test site here: http://docstest.moodle.local/all/es/P ágina_Principal I think thats working exactly as we want it, but the lack of the combined wiki image is because there is a broken image reference - mediawiki doesn't like loosing its logo!
            Hide
            Helen Foster added a comment -

            Great work Dan - all combined wikis tested and working fine

            Just one small thing which I found weird: links on a page e.g. http://docstest.moodle.local/all/es/P%C3%A1gina_Principal still have 19 in the URL.

            Show
            Helen Foster added a comment - Great work Dan - all combined wikis tested and working fine Just one small thing which I found weird: links on a page e.g. http://docstest.moodle.local/all/es/P%C3%A1gina_Principal still have 19 in the URL.
            Dan Poltawski made changes -
            Link This issue has a non-specific relationship to MDLSITE-1734 [ MDLSITE-1734 ]
            Hide
            Dan Poltawski added a comment -

            This has been deployed - combined wikis are now /all

            Show
            Dan Poltawski added a comment - This has been deployed - combined wikis are now /all
            Dan Poltawski made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            Séverin Terrier added a comment -

            Not the good moment to do that on french wiki
            French community just asked for a 1.9 (1.x) wiki, and a 2.x wiki : MDLSITE-1734

            Show
            Séverin Terrier added a comment - Not the good moment to do that on french wiki French community just asked for a 1.9 (1.x) wiki, and a 2.x wiki : MDLSITE-1734
            Hide
            Séverin Terrier added a comment -

            Please don't let things like that to long : after "fr", "19/fr", "all/fr"... it will just confuse everybody... and generates risks of bad link in forums...

            Show
            Séverin Terrier added a comment - Please don't let things like that to long : after "fr", "19/fr", "all/fr"... it will just confuse everybody... and generates risks of bad link in forums...
            Hide
            Helen Foster added a comment -

            Séverin, apologies if the timing of this issue fix causes confusion. It's been open for a number of months and I've heard various reports about '19' causing confusion.

            You've probably noticed that http://docs.moodle.org/19/fr/Accueil redirects to http://docs.moodle.org/all/fr/Accueil so hopefully there won't be broken links in the forum.

            Show
            Helen Foster added a comment - Séverin, apologies if the timing of this issue fix causes confusion. It's been open for a number of months and I've heard various reports about '19' causing confusion. You've probably noticed that http://docs.moodle.org/19/fr/Accueil redirects to http://docs.moodle.org/all/fr/Accueil so hopefully there won't be broken links in the forum.
            Hide
            Dan Poltawski added a comment -

            Hi Séverin,

            Sorry about this - I had hoped to get the 2x wiki ready for you today to use today and the redirects changed away to reflect that.

            dan

            Show
            Dan Poltawski added a comment - Hi Séverin, Sorry about this - I had hoped to get the 2x wiki ready for you today to use today and the redirects changed away to reflect that. dan
            Hide
            Séverin Terrier added a comment -

            Helen : Yes, i've seen that redirections are OK
            Dan : If you're working on it (nice to know it), and it's just a question of day(s), it should not be a problem. Thanks in advance.

            Show
            Séverin Terrier added a comment - Helen : Yes, i've seen that redirections are OK Dan : If you're working on it (nice to know it), and it's just a question of day(s), it should not be a problem. Thanks in advance.
            Martin Dougiamas made changes -
            Workflow jira [ 99512 ] SITES Full Workflow [ 126463 ]
            Martin Dougiamas made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            Helen Foster made changes -
            Workflow SITES Full Workflow [ 126463 ] SITES workflow plus [ 137038 ]

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development