Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: moodle.org/plugins
    • Labels:
      None

      Description

      there is no need in text field for Documentation.
      A link to the external documentation should be moved into Project home (Description) tab

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              marina Marina Glancy added a comment -
              • removed files docs.php, docs_edit.php
              • removed tab Docs from plugin info and link to edit docs
              • removed function plugin_documentation() from renderer.php
              • added field documentationurl to the edit plugin form
              • added documentation url link to the plugin description page
              • added missing links to website url and source control url to the plugin description page
              • changed/added strings for consistency
              • code responsible for displaying of the plugin description page is moved to renderer.php
              Show
              marina Marina Glancy added a comment - removed files docs.php, docs_edit.php removed tab Docs from plugin info and link to edit docs removed function plugin_documentation() from renderer.php added field documentationurl to the edit plugin form added documentation url link to the plugin description page added missing links to website url and source control url to the plugin description page changed/added strings for consistency code responsible for displaying of the plugin description page is moved to renderer.php
              Hide
              marina Marina Glancy added a comment -

              Petr, can you review this please. The most of the task is already submitted, reviewed by Sam and merged.

              I noticed that I forgot to alter registerplugin_form as well:
              https://github.com/moodlehq/moodle-local_plugins/compare/master...wip-HQ-128-2-master

              Also found a bug that "create new plugin" link is displayed for users without the proper capability. Fixed it within the same issue, thought the change was too small to create the separate issue

              Show
              marina Marina Glancy added a comment - Petr, can you review this please. The most of the task is already submitted, reviewed by Sam and merged. I noticed that I forgot to alter registerplugin_form as well: https://github.com/moodlehq/moodle-local_plugins/compare/master...wip-HQ-128-2-master Also found a bug that "create new plugin" link is displayed for users without the proper capability. Fixed it within the same issue, thought the change was too small to create the separate issue
              Hide
              skodak Petr Skoda added a comment -

              Merged to master, there is one small issue only - the commit message should contain one relatively "short" line with description and if necessary extra explanation text in a separate text block separated with empty line. Thanks.

              Show
              skodak Petr Skoda added a comment - Merged to master, there is one small issue only - the commit message should contain one relatively "short" line with description and if necessary extra explanation text in a separate text block separated with empty line. Thanks.
              Hide
              skodak Petr Skoda added a comment -

              Should I be closing these bugs after merge?

              Show
              skodak Petr Skoda added a comment - Should I be closing these bugs after merge?
              Hide
              marina Marina Glancy added a comment -

              Petr, yes please. There is no normal workflow on HQ tasks, I can not mark as "submit for integration"

              Show
              marina Marina Glancy added a comment - Petr, yes please. There is no normal workflow on HQ tasks, I can not mark as "submit for integration"

                People

                • Assignee:
                  marina Marina Glancy
                  Reporter:
                  marina Marina Glancy
                  Peer reviewer:
                  Sam Hemelryk
                  Participants:
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: