Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Component/s: moodle.org/plugins
    • Labels:
      None
    • Rank:
      19922

      Description

      there is no need in text field for Documentation.
      A link to the external documentation should be moved into Project home (Description) tab

        Issue Links

          Activity

          Marina Glancy created issue -
          Marina Glancy made changes -
          Field Original Value New Value
          Priority Minor [ 4 ] Critical [ 2 ]
          Hide
          Marina Glancy added a comment -
          • removed files docs.php, docs_edit.php
          • removed tab Docs from plugin info and link to edit docs
          • removed function plugin_documentation() from renderer.php
          • added field documentationurl to the edit plugin form
          • added documentation url link to the plugin description page
          • added missing links to website url and source control url to the plugin description page
          • changed/added strings for consistency
          • code responsible for displaying of the plugin description page is moved to renderer.php
          Show
          Marina Glancy added a comment - removed files docs.php, docs_edit.php removed tab Docs from plugin info and link to edit docs removed function plugin_documentation() from renderer.php added field documentationurl to the edit plugin form added documentation url link to the plugin description page added missing links to website url and source control url to the plugin description page changed/added strings for consistency code responsible for displaying of the plugin description page is moved to renderer.php
          Marina Glancy made changes -
          Pull Master Diff URL https://github.com/moodlehq/moodle-local_plugins/compare/master...wip-HQ-128-master
          Pull Master Branch wip-HQ-128-master
          Pull from Repository git@github.com:moodlehq/moodle-local_plugins.git
          Marina Glancy made changes -
          Peer reviewer samhemelryk
          Assignee Sam Hemelryk [ samhemelryk ] Marina Glancy [ marina ]
          Marina Glancy made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          Marina Glancy added a comment -

          Petr, can you review this please. The most of the task is already submitted, reviewed by Sam and merged.

          I noticed that I forgot to alter registerplugin_form as well:
          https://github.com/moodlehq/moodle-local_plugins/compare/master...wip-HQ-128-2-master

          Also found a bug that "create new plugin" link is displayed for users without the proper capability. Fixed it within the same issue, thought the change was too small to create the separate issue

          Show
          Marina Glancy added a comment - Petr, can you review this please. The most of the task is already submitted, reviewed by Sam and merged. I noticed that I forgot to alter registerplugin_form as well: https://github.com/moodlehq/moodle-local_plugins/compare/master...wip-HQ-128-2-master Also found a bug that "create new plugin" link is displayed for users without the proper capability. Fixed it within the same issue, thought the change was too small to create the separate issue
          Marina Glancy made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Hide
          Petr Škoda added a comment -

          Merged to master, there is one small issue only - the commit message should contain one relatively "short" line with description and if necessary extra explanation text in a separate text block separated with empty line. Thanks.

          Show
          Petr Škoda added a comment - Merged to master, there is one small issue only - the commit message should contain one relatively "short" line with description and if necessary extra explanation text in a separate text block separated with empty line. Thanks.
          Hide
          Petr Škoda added a comment -

          Should I be closing these bugs after merge?

          Show
          Petr Škoda added a comment - Should I be closing these bugs after merge?
          Hide
          Marina Glancy added a comment -

          Petr, yes please. There is no normal workflow on HQ tasks, I can not mark as "submit for integration"

          Show
          Marina Glancy added a comment - Petr, yes please. There is no normal workflow on HQ tasks, I can not mark as "submit for integration"
          Petr Škoda made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Marina Glancy made changes -
          Link This issue is duplicated by HQ-114 [ HQ-114 ]
          Marina Glancy made changes -
          Project Moodle HQ [ 10050 ] Moodle Community Sites [ 10020 ]
          Key HQ-128 MDLSITE-1453
          Affects Version/s current version [ 10512 ]
          Component/s Plugins database [ 11146 ]
          Marina Glancy made changes -
          Component/s moodle.org/plugins [ 11432 ]
          Martin Dougiamas made changes -
          Workflow jira [ 98933 ] SITES Full Workflow [ 127353 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development