Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: moodle.org/plugins
    • Labels:
      None

      Description

      disapproved->unapproved
      disapprove->unapprove
      etc.

        Gliffy Diagrams

          Activity

          marina Marina Glancy created issue -
          marina Marina Glancy made changes -
          Field Original Value New Value
          Priority Minor [ 4 ] Critical [ 2 ]
          Assignee Sam Hemelryk [ samhemelryk ] Marina Glancy [ marina ]
          Hide
          andyjdavis Andrew Davis added a comment - - edited

          Perhaps we want to use "reject" or "needs more work". Unapprove is an ambiguous term that could mean either waiting for approval or rejected.

          if you're going to be modifying all of the related strings perhaps "waiting for approval", "approved" and "needs more work" for when its been rejected.

          Show
          andyjdavis Andrew Davis added a comment - - edited Perhaps we want to use "reject" or "needs more work". Unapprove is an ambiguous term that could mean either waiting for approval or rejected. if you're going to be modifying all of the related strings perhaps "waiting for approval", "approved" and "needs more work" for when its been rejected.
          Hide
          tsala Helen Foster added a comment -

          My suggestion is "Waiting for approval".

          Show
          tsala Helen Foster added a comment - My suggestion is "Waiting for approval".
          Hide
          marina Marina Glancy added a comment -

          Thanks very much for your help.
          The strings are the following at the moment:

          For contributors:

          $string['notapproved'] = 'Needs more work'; // status
          $string['pendingapproval'] = 'Waiting for approval'; // status
          $string['approved'] = 'Approved'; //status
          $string['scheduleapprove'] = 'Request re-approval'; // button for a version
          $string['scheduleapprovethisplugin'] = 'Schedule this plugin for re-approval'; //link for a plugin

          For admins:
          when plugin is contributed admin has the following links (buttons)
          $string['approve'] = 'Approve'; // button for a version/plugin
          $string['approvethisplugin'] = 'Approve this plugin'; // link for a plugin
          $string['disapprove'] = 'Unapprove'; // button for a version/plugin
          $string['disapprovethisplugin'] = 'Unapprove this plugin'; // link for a plugin

          Reports names and descriptions:

          $string['report_unapprovedplugins'] = 'Unapproved plugins';
          $string['report_unapprovedpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have been unapproved.';
          $string['report_unapprovedversions'] = 'Unapproved versions';
          $string['report_unapprovedversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have been unapproved.';
          $string['report_pendingapprovalplugins'] = 'Waiting for approval plugins';
          $string['report_pendingapprovalpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have not yet been approved.';
          $string['report_pendingapprovalversions'] = 'Waiting for approval versions';
          $string['report_pendingapprovalversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have not yet been approved.';

          Show
          marina Marina Glancy added a comment - Thanks very much for your help. The strings are the following at the moment: For contributors: $string ['notapproved'] = 'Needs more work'; // status $string ['pendingapproval'] = 'Waiting for approval'; // status $string ['approved'] = 'Approved'; //status $string ['scheduleapprove'] = 'Request re-approval'; // button for a version $string ['scheduleapprovethisplugin'] = 'Schedule this plugin for re-approval'; //link for a plugin For admins: when plugin is contributed admin has the following links (buttons) $string ['approve'] = 'Approve'; // button for a version/plugin $string ['approvethisplugin'] = 'Approve this plugin'; // link for a plugin $string ['disapprove'] = 'Unapprove'; // button for a version/plugin $string ['disapprovethisplugin'] = 'Unapprove this plugin'; // link for a plugin Reports names and descriptions: $string ['report_unapprovedplugins'] = 'Unapproved plugins'; $string ['report_unapprovedpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have been unapproved.'; $string ['report_unapprovedversions'] = 'Unapproved versions'; $string ['report_unapprovedversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have been unapproved.'; $string ['report_pendingapprovalplugins'] = 'Waiting for approval plugins'; $string ['report_pendingapprovalpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have not yet been approved.'; $string ['report_pendingapprovalversions'] = 'Waiting for approval versions'; $string ['report_pendingapprovalversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have not yet been approved.';
          marina Marina Glancy made changes -
          Pull Master Diff URL https://github.com/moodlehq/moodle-local_plugins/compare/master...wip-HQ-137-master
          Pull Master Branch wip-HQ-137-master
          Pull from Repository git@github.com:moodlehq/moodle-local_plugins.git
          Hide
          marina Marina Glancy added a comment -

          Petr, integrate this change please. Thank you

          Show
          marina Marina Glancy added a comment - Petr, integrate this change please. Thank you
          marina Marina Glancy made changes -
          Peer reviewer skodak
          Hide
          marina Marina Glancy added a comment -

          merged into master

          Show
          marina Marina Glancy added a comment - merged into master
          marina Marina Glancy made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          marina Marina Glancy made changes -
          Project Moodle HQ [ 10050 ] Moodle Community Sites [ 10020 ]
          Key HQ-137 MDLSITE-1459
          Affects Version/s current version [ 10512 ]
          Component/s Plugins database [ 11146 ]
          marina Marina Glancy made changes -
          Component/s moodle.org/plugins [ 11432 ]
          dougiamas Martin Dougiamas made changes -
          Workflow jira [ 99492 ] SITES Full Workflow [ 126462 ]
          dougiamas Martin Dougiamas made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          tsala Helen Foster made changes -
          Workflow SITES Full Workflow [ 126462 ] SITES workflow plus [ 137037 ]
          Subversion JIRA

          Links Hierarchy

           Documentation

          Invalid license: EXPIRED

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development