Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Component/s: moodle.org/plugins
    • Labels:
      None
    • Rank:
      19928

      Description

      disapproved->unapproved
      disapprove->unapprove
      etc.

        Activity

        Hide
        Andrew Davis added a comment - - edited

        Perhaps we want to use "reject" or "needs more work". Unapprove is an ambiguous term that could mean either waiting for approval or rejected.

        if you're going to be modifying all of the related strings perhaps "waiting for approval", "approved" and "needs more work" for when its been rejected.

        Show
        Andrew Davis added a comment - - edited Perhaps we want to use "reject" or "needs more work". Unapprove is an ambiguous term that could mean either waiting for approval or rejected. if you're going to be modifying all of the related strings perhaps "waiting for approval", "approved" and "needs more work" for when its been rejected.
        Hide
        Helen Foster added a comment -

        My suggestion is "Waiting for approval".

        Show
        Helen Foster added a comment - My suggestion is "Waiting for approval".
        Hide
        Marina Glancy added a comment -

        Thanks very much for your help.
        The strings are the following at the moment:

        For contributors:

        $string['notapproved'] = 'Needs more work'; // status
        $string['pendingapproval'] = 'Waiting for approval'; // status
        $string['approved'] = 'Approved'; //status
        $string['scheduleapprove'] = 'Request re-approval'; // button for a version
        $string['scheduleapprovethisplugin'] = 'Schedule this plugin for re-approval'; //link for a plugin

        For admins:
        when plugin is contributed admin has the following links (buttons)
        $string['approve'] = 'Approve'; // button for a version/plugin
        $string['approvethisplugin'] = 'Approve this plugin'; // link for a plugin
        $string['disapprove'] = 'Unapprove'; // button for a version/plugin
        $string['disapprovethisplugin'] = 'Unapprove this plugin'; // link for a plugin

        Reports names and descriptions:

        $string['report_unapprovedplugins'] = 'Unapproved plugins';
        $string['report_unapprovedpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have been unapproved.';
        $string['report_unapprovedversions'] = 'Unapproved versions';
        $string['report_unapprovedversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have been unapproved.';
        $string['report_pendingapprovalplugins'] = 'Waiting for approval plugins';
        $string['report_pendingapprovalpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have not yet been approved.';
        $string['report_pendingapprovalversions'] = 'Waiting for approval versions';
        $string['report_pendingapprovalversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have not yet been approved.';

        Show
        Marina Glancy added a comment - Thanks very much for your help. The strings are the following at the moment: For contributors: $string ['notapproved'] = 'Needs more work'; // status $string ['pendingapproval'] = 'Waiting for approval'; // status $string ['approved'] = 'Approved'; //status $string ['scheduleapprove'] = 'Request re-approval'; // button for a version $string ['scheduleapprovethisplugin'] = 'Schedule this plugin for re-approval'; //link for a plugin For admins: when plugin is contributed admin has the following links (buttons) $string ['approve'] = 'Approve'; // button for a version/plugin $string ['approvethisplugin'] = 'Approve this plugin'; // link for a plugin $string ['disapprove'] = 'Unapprove'; // button for a version/plugin $string ['disapprovethisplugin'] = 'Unapprove this plugin'; // link for a plugin Reports names and descriptions: $string ['report_unapprovedplugins'] = 'Unapproved plugins'; $string ['report_unapprovedpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have been unapproved.'; $string ['report_unapprovedversions'] = 'Unapproved versions'; $string ['report_unapprovedversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have been unapproved.'; $string ['report_pendingapprovalplugins'] = 'Waiting for approval plugins'; $string ['report_pendingapprovalpluginsdesc'] = 'This report contains all of the plugins that exist within the system but have not yet been approved.'; $string ['report_pendingapprovalversions'] = 'Waiting for approval versions'; $string ['report_pendingapprovalversionsdesc'] = 'This report contains all of the plugin versions that exist within the system but have not yet been approved.';
        Hide
        Marina Glancy added a comment -

        Petr, integrate this change please. Thank you

        Show
        Marina Glancy added a comment - Petr, integrate this change please. Thank you
        Hide
        Marina Glancy added a comment -

        merged into master

        Show
        Marina Glancy added a comment - merged into master

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development