Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-1715

Cloudflare getting in the way of file uploads

    Details

      Description

      We've seen some issues whilst uploading files to moodle.org where cloudflare is presenting a captcha. Unfortunately, the filepicker expects ajax and goes bang in an unpleasant fashion.

      The file that Jenny Gray was trying and I was able to replicate was a zip of a git project directory so it contained the entire .git directory and all of the objects within.
      Removing the .git directory made it work, but so did only zipping up the .git directory so it appears that it's a combination of all of the content which causes the issues to appear.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            tsala Helen Foster added a comment -

            Andrew, thanks for your report. Adding Jordan as watcher.

            Show
            tsala Helen Foster added a comment - Andrew, thanks for your report. Adding Jordan as watcher.
            Hide
            jtomkinson Jordan Tomkinson added a comment -

            Please try again and let me know if you get the same result (i have changed backend magic)

            Show
            jtomkinson Jordan Tomkinson added a comment - Please try again and let me know if you get the same result (i have changed backend magic)
            Hide
            dobedobedoh Andrew Nicols added a comment -

            All working now thanks

            Show
            dobedobedoh Andrew Nicols added a comment - All working now thanks
            Hide
            tsala Helen Foster added a comment -

            Thanks Jordan for your magic

            Show
            tsala Helen Foster added a comment - Thanks Jordan for your magic
            Hide
            danmarsden Dan Marsden added a comment -

            Hi Jordan,

            looks like this is occurring for demo.moodle.net and qa.moodle.net again:
            http://moodle.org/mod/forum/discuss.php?d=200725

            Show
            danmarsden Dan Marsden added a comment - Hi Jordan, looks like this is occurring for demo.moodle.net and qa.moodle.net again: http://moodle.org/mod/forum/discuss.php?d=200725
            Hide
            jtomkinson Jordan Tomkinson added a comment -

            The cloudflare settings for moodle.net have not changed (and are different from moodle.org), please give steps to reproduce so I can test

            Show
            jtomkinson Jordan Tomkinson added a comment - The cloudflare settings for moodle.net have not changed (and are different from moodle.org), please give steps to reproduce so I can test
            Hide
            danmarsden Dan Marsden added a comment -

            try creating a SCORM on those sites and uploading a zip - here's one:
            http://moodle.org/mod/data/view.php?d=50&rid=1655

            Show
            danmarsden Dan Marsden added a comment - try creating a SCORM on those sites and uploading a zip - here's one: http://moodle.org/mod/data/view.php?d=50&rid=1655
            Hide
            danmarsden Dan Marsden added a comment -

            btw - I'd love to see a post from you about your experience with cloudflare! - the gotcha's, any config you've found that works etc!

            Show
            danmarsden Dan Marsden added a comment - btw - I'd love to see a post from you about your experience with cloudflare! - the gotcha's, any config you've found that works etc!
            Hide
            jtomkinson Jordan Tomkinson added a comment -

            so far its a trade off between security and usability
            if you have the time & resources to build your own WAF, do it.

            Show
            jtomkinson Jordan Tomkinson added a comment - so far its a trade off between security and usability if you have the time & resources to build your own WAF, do it.
            Hide
            tsala Helen Foster added a comment -

            I'm also running into this problem when attempting to upload a course backup to the demo and qa sites.

            Steps to reproduce:

            1. Download a course backup from MOOCH
            2. Log in as admin to http://demo.moodle.net/
            3. Go to Settings > Front page settings > Restore and attempt to upload the backup file

            The following error message is displayed in the file picker:

            ERROR: Invalid JSON string

            This field helps us determine that you are human, and not an automated program trying to compromise the security system.

            Show
            tsala Helen Foster added a comment - I'm also running into this problem when attempting to upload a course backup to the demo and qa sites. Steps to reproduce: 1. Download a course backup from MOOCH 2. Log in as admin to http://demo.moodle.net/ 3. Go to Settings > Front page settings > Restore and attempt to upload the backup file The following error message is displayed in the file picker: ERROR: Invalid JSON string This field helps us determine that you are human, and not an automated program trying to compromise the security system.
            Hide
            matteo Matteo Scaramuccia added a comment -

            Hi,
            it sounds like the AV component of CloudFlare has been triggered:

                    <div id="RecaptchaTip" class="tip hidden">
                        <span>
                            This field helps us determine that you are human, and not an automated program trying to compromise the security system.            </span>
                    </div> <!-- #RecaptchaTip.tip.hidden -->

            probably by delivering this page, http://anti-virus.cloudflare.com/cdn-cgi/anti-virus-challenge, to the final user.

            It requires Fiddler or Firebug to see if the Moodle response has been really replaced on-the-fly by that page above. This should explain the JSON error since that HTML is not a valid (and expected) JSON reply.

            HTH,
            Matteo

            Show
            matteo Matteo Scaramuccia added a comment - Hi, it sounds like the AV component of CloudFlare has been triggered: <div id="RecaptchaTip" class="tip hidden"> <span> This field helps us determine that you are human, and not an automated program trying to compromise the security system. </span> </div> <!-- #RecaptchaTip.tip.hidden --> probably by delivering this page, http://anti-virus.cloudflare.com/cdn-cgi/anti-virus-challenge , to the final user. It requires Fiddler or Firebug to see if the Moodle response has been really replaced on-the-fly by that page above. This should explain the JSON error since that HTML is not a valid (and expected) JSON reply. HTH, Matteo
            Hide
            davosmith Davo Smith added a comment -

            I'm currently unable to add the latest version of my uploadpdf assignment plugin due to this problem.

            I can navigate the rest of the Moodle.org site without difficulty, but every attempt to upload my plugin hits the same JSON error + message about checking that I am human.

            Show
            davosmith Davo Smith added a comment - I'm currently unable to add the latest version of my uploadpdf assignment plugin due to this problem. I can navigate the rest of the Moodle.org site without difficulty, but every attempt to upload my plugin hits the same JSON error + message about checking that I am human.
            Hide
            poltawski Dan Poltawski added a comment -

            Hi All,

            Sorry for this, it seems to be a configuration change which was done yesterday. Should be resolved.

            Please open a new issue if this is still a problem

            Show
            poltawski Dan Poltawski added a comment - Hi All, Sorry for this, it seems to be a configuration change which was done yesterday. Should be resolved. Please open a new issue if this is still a problem
            Hide
            marycooch Mary Cooch added a comment -

            just adding schooldemo too as that's how I realised the issue affected demo and QA as well

            Show
            marycooch Mary Cooch added a comment - just adding schooldemo too as that's how I realised the issue affected demo and QA as well
            Hide
            davosmith Davo Smith added a comment -

            Working now for me on the plugins database

            Show
            davosmith Davo Smith added a comment - Working now for me on the plugins database
            Hide
            marycooch Mary Cooch added a comment -

            and on all 3 demo sites too thanks

            Show
            marycooch Mary Cooch added a comment - and on all 3 demo sites too thanks

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: