Moodle Community Sites
  1. Moodle Community Sites
  2. MDLSITE-1862 META: Moodle.org reboot
  3. MDLSITE-1724

Make use of local_dev to populate cohort and control dev chat log access

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Component/s: moodle.org
    • Labels:
    • Rank:
      38354

      Description

      From dev chat http://moodle.org/mod/cvsadmin/view.php?conversationid=9572#c334037

      Dev chat logs should be converted into a local plugin or perhaps part of local_dev, so that access is restricted to people in the dev database only.

      Also the dev database should populate a cohort which would then populate groups across courses

        Issue Links

          Activity

          Helen Foster created issue -
          Hide
          Helen Foster added a comment -

          Assigning to super-Dan and adding Martin as a watcher for any further comments.

          Show
          Helen Foster added a comment - Assigning to super-Dan and adding Martin as a watcher for any further comments.
          Helen Foster made changes -
          Field Original Value New Value
          Priority Minor [ 4 ] Major [ 3 ]
          Labels triaged
          Assignee Helen Foster [ tsala ] Dan Poltawski [ poltawski ]
          David Mudrak made changes -
          Link This issue will be resolved by MDLSITE-1663 [ MDLSITE-1663 ]
          Hide
          Dan Poltawski added a comment -

          Just was going through the old plugin with Jordan.

          Question regarding the 'auth' for access to chat logs..

          • Do we allow anyone in the dev database access (even some old troublemaker - we might want to remove access perhaps?)
          • There might be cases for people who don't have a record in the dev database e.g. HQ syadmin etc
          Show
          Dan Poltawski added a comment - Just was going through the old plugin with Jordan. Question regarding the 'auth' for access to chat logs.. Do we allow anyone in the dev database access (even some old troublemaker - we might want to remove access perhaps?) There might be cases for people who don't have a record in the dev database e.g. HQ syadmin etc
          Hide
          Dan Poltawski added a comment -

          Discussed this with MD, we decided on:

          Allow access if you have either a capability [e.g.] chatlog:viewlogs

          OR

          Allow access if in 'git commiters' cohort AND don't have the chatlog:banned capability

          Show
          Dan Poltawski added a comment - Discussed this with MD, we decided on: Allow access if you have either a capability [e.g.] chatlog:viewlogs OR Allow access if in 'git commiters' cohort AND don't have the chatlog:banned capability
          Hide
          Dan Poltawski added a comment -

          Turns out that last comment wasn't sensible due to the negative capability - admins always have positive capability.

          So instead I added a view capability and a 'viewifdeveloper' capability. The viewifdeveloper capability will be added to the loggedinuser role and only if in the developer cohort and have that capability can you access it. We can deal with 'naughty' users by prohibiting it.

          Show
          Dan Poltawski added a comment - Turns out that last comment wasn't sensible due to the negative capability - admins always have positive capability. So instead I added a view capability and a 'viewifdeveloper' capability. The viewifdeveloper capability will be added to the loggedinuser role and only if in the developer cohort and have that capability can you access it. We can deal with 'naughty' users by prohibiting it.
          Hide
          Dan Poltawski added a comment -

          Added David here..

          David: I have added a 'cohort sync' script to the dev plugin and pushed it to 'danp-sync-cohorts' branch:
          https://github.com/moodlehq/moodle-local_dev/commit/dea87f7349ca533703c5b6f305ed0785bac821ee

          I was unsure about integrating it properly into your local_dev overall architecture so wanted to discuss it.

          Show
          Dan Poltawski added a comment - Added David here.. David: I have added a 'cohort sync' script to the dev plugin and pushed it to 'danp-sync-cohorts' branch: https://github.com/moodlehq/moodle-local_dev/commit/dea87f7349ca533703c5b6f305ed0785bac821ee I was unsure about integrating it properly into your local_dev overall architecture so wanted to discuss it.
          Hide
          Dan Poltawski added a comment -

          Hi David, re-looking at this and it seems your comments have been lost on the commit because you deleted the AMOS user.

          I've forgotten what was discussed on the line in question. Are you able to re-comment? thanks

          Show
          Dan Poltawski added a comment - Hi David, re-looking at this and it seems your comments have been lost on the commit because you deleted the AMOS user. I've forgotten what was discussed on the line in question. Are you able to re-comment? thanks
          Hide
          David Mudrak added a comment -

          Hmm. Apparently I suggested to use

          {dev_git_commits} table instead of {dev_git_user_aliases}. The question is why I did it. As thinking about it now, it seems to me that using user aliases table is valid. Could it be that we had planned to track multiple repositories (see the column repository in {dev_git_commits}

          ) and that only commits in moodle.git should be taken into account? If that was the reason, I don't think that adding additional repos would happen anytime soon...

          Show
          David Mudrak added a comment - Hmm. Apparently I suggested to use {dev_git_commits} table instead of {dev_git_user_aliases}. The question is why I did it. As thinking about it now, it seems to me that using user aliases table is valid. Could it be that we had planned to track multiple repositories (see the column repository in {dev_git_commits} ) and that only commits in moodle.git should be taken into account? If that was the reason, I don't think that adding additional repos would happen anytime soon...
          Hide
          Dan Poltawski added a comment -

          Just found your original comment in my emails:
          "This is not enough. The table

          {dev_git_user_aliases} provides just explicit mappings - that is a mapping based on some additional email address than the one currently used by the user at moodle.org. If some developer has the same email in the Moodle profile and in the Git commit, no alias is created for them and the userid is stored directly in {dev_git_commits}

          So we need something like

          SELECT DISTINCT userid FROM {dev_git_user_aliases}

          UNION ALL SELECT DISTINCT userid FROM

          {dev_git_commits}

          "

          Show
          Dan Poltawski added a comment - Just found your original comment in my emails: "This is not enough. The table {dev_git_user_aliases} provides just explicit mappings - that is a mapping based on some additional email address than the one currently used by the user at moodle.org. If some developer has the same email in the Moodle profile and in the Git commit, no alias is created for them and the userid is stored directly in {dev_git_commits} So we need something like SELECT DISTINCT userid FROM {dev_git_user_aliases} UNION ALL SELECT DISTINCT userid FROM {dev_git_commits} "
          Hide
          Dan Poltawski added a comment -

          Hi David,

          I'm back pinging about this one again. We've got everything in place in moodle.org now so that the devs group on the forums can be synced from this cohort as well as access-control for the chatlogs to be controlled by it. So I really should ge this bug resolved!

          Could you review the changes so we can declare whether this could be added? (Particularly I wasn't really sure where we should fit this into the the architecture of the dev plugin).

          Show
          Dan Poltawski added a comment - Hi David, I'm back pinging about this one again. We've got everything in place in moodle.org now so that the devs group on the forums can be synced from this cohort as well as access-control for the chatlogs to be controlled by it. So I really should ge this bug resolved! Could you review the changes so we can declare whether this could be added? (Particularly I wasn't really sure where we should fit this into the the architecture of the dev plugin).
          Hide
          David Mudrak added a comment -

          This is at very top of my todo list now and I will work on it as soon as I'm back from a short break.

          Show
          David Mudrak added a comment - This is at very top of my todo list now and I will work on it as soon as I'm back from a short break.
          Hide
          David Mudrak added a comment -

          Hi Dan,

          the SQL needs to be fixed to fetch userids from both tables mentioned in my comment. The userid field is a foreign key in

          {dev_git_commits}

          . In case this is not enough for the RDBMS at moodle.org and it will refuse to use the implicit index to obtain DISTINCT userid, we may try to create the explicit index yet.

          Otherwise, the code looks ok to me (as long as we do not want to prepare a more complex SQL that would already look into

          {cohort_members}

          and would return just those who are missing. For now, I would prefer your solution though.

          Show
          David Mudrak added a comment - Hi Dan, the SQL needs to be fixed to fetch userids from both tables mentioned in my comment. The userid field is a foreign key in {dev_git_commits} . In case this is not enough for the RDBMS at moodle.org and it will refuse to use the implicit index to obtain DISTINCT userid, we may try to create the explicit index yet. Otherwise, the code looks ok to me (as long as we do not want to prepare a more complex SQL that would already look into {cohort_members} and would return just those who are missing. For now, I would prefer your solution though.
          Helen Foster made changes -
          Parent MDLSITE-1862 [ 58122 ]
          Issue Type Improvement [ 4 ] Sub-task [ 5 ]
          Hide
          Helen Foster added a comment -

          Just noting that every course on moodle.org now has a core developers group and a cohort members to group enrolment method for the group to be populated from the developers cohort.

          Show
          Helen Foster added a comment - Just noting that every course on moodle.org now has a core developers group and a cohort members to group enrolment method for the group to be populated from the developers cohort.
          Hide
          Dan Poltawski added a comment -

          Correcting that query makes quite a big difference.. 826 users on the clone rather than 550.

          What i'm a little confused by is some aliases i've spotted without any commits.

          Show
          Dan Poltawski added a comment - Correcting that query makes quite a big difference.. 826 users on the clone rather than 550. What i'm a little confused by is some aliases i've spotted without any commits.
          Hide
          Martin Dougiamas added a comment -

          These seem to make sense to me (except guest).

          Show
          Martin Dougiamas added a comment - These seem to make sense to me (except guest).
          Hide
          Dan Poltawski added a comment -

          Looks like we've got a lot of unused alaises:

          SELECT a.*
          FROM dev_git_user_aliases a
          LEFT JOIN dev_git_commits c ON a.userid = c.userid
          WHERE c.userid IS NULL;

          Show
          Dan Poltawski added a comment - Looks like we've got a lot of unused alaises: SELECT a.* FROM dev_git_user_aliases a LEFT JOIN dev_git_commits c ON a.userid = c.userid WHERE c.userid IS NULL;
          Dan Poltawski made changes -
          Comment [ I updated the patch: https://github.com/moodlehq/moodle-local_dev/compare/danp-sync-cohorts

          And I installed it on the clone and tested it out, then I wrote some (horrible) queries to work out who is in the chat cohort, but not in developers list:

          {code}
          mysql> SELECT firstname, lastname FROM user WHERE id IN (SELECT userid FROM cohort_members WHERE cohortid = 5 AND userid NOT IN (SELECT userid FROM cohort_members WHERE cohortid = 9));
          +-----------+--------------+
          | firstname | lastname |
          +-----------+--------------+
          | Michael | Spall |
          | Sam | Test |
          | Mary | Cooch |
          | Kris | Stokking |
          | Bree | Vreedenburgh |
          +-----------+--------------+
          5 rows in set (3.44 sec)
          {code} ]
          Dan Poltawski made changes -
          Comment [ Hrm. Then the other way round (a bit weird, guest user in there):
          {code}
          mysql> SELECT firstname, lastname FROM user WHERE id IN (SELECT userid FROM cohort_members WHERE cohortid = 9 AND userid NOT IN (SELECT userid FROM cohort_members WHERE cohortid = 5));
          +-------------------------+-----------------------------------------+
          | firstname | lastname |
          +-------------------------+-----------------------------------------+
          | Guest | User |
          | Hans | de Zwart |
          | Thomas | Robb |
          | Ahmed | Nabil |
          | Holger | Schadeck |
          | Claudio | Tavares |
          | Antonio | Navarro |
          | Juraj | Chlebec |
          | Zhang | dexuan |
          | Set | Lonnert |
          | Ray | Kingdon |
          | Greg | Barnett |
          | Michael | Schneider |
          | Istvan | Bozsa |
          | Scott | Elliott |
          | Paul | Shew |
          | Palo | Jacko |
          | Stig Bjarne | Haugen |
          | John | Gone |
          | Zbigniew | Fiedorowicz |
          | Les | Kopari |
          | Daniel | Fetzer |
          | Pablo | Etcheverry |
          | David | Scotson |
          | Anders | Berggren |
          | Dr. Ali | Abureesh |
          | Henrik | Kaipe |
          | Russell | Jungwirth |
          | Andrew | Redkin |
          | Christian | Borowski |
          | Williams | Castillo |
          | Thanh | Le |
          | Dan | Stowell |
          | Daryl | Hawes |
          | Kristian | Nielsen |
          | André | Krüger |
          | Jan | Dierckx |
          | Carsten | Schmitz |
          | Hung | Viet Nam |
          | Markus | Hagman |
          | Enrique | Castro |
          | Ziba | Scott |
          | Andreas | Grabs |
          | ไพฑูรย์ | ทิพย์สันเทียะ |
          | Girts | Ozolins |
          | Anoochit | Chalothorn |
          | Jeff | Graham |
          | Brian | King |
          | Julian | Sedding |
          | Joey | Kendall-Morwick |
          | dovix | :) |
          | Paul | Daniels |
          | Dave | Balch |
          | romuald | lorthioir |
          | Aaron | Spike |
          | Ling | Li |
          | Fei | Yang |
          | Stephen | Bourget |
          | Andrew | Ivanov |
          | Lasha | Altunashvili |
          | Đinh Lư | Giang |
          | Zhigang | Sun |
          | Myles | Carrick |
          | Patrick | Li |
          | Charles | Severance |
          | 이찬영 | Lee Chan-young |
          | Tomaž | Savodnik |
          | Yu | Zhang |
          | Vy-Shane | Sin Fat |
          | Takayuki | ISHIKAWA |
          | Andar | Hutasoit |
          | Somsack | INTHASONE |
          | Sam | Chaffee |
          | Eloys | Lafuentes |
          | Manh Cuong | Nguyen |
          | Nagalingam | Kuhan |
          | Tom | Flannaghan |
          | Michael | Champanis |
          | Vincenzo K. | Marcovecchio |
          | Ed | Coyne |
          | Ken | Wilson |
          | David | Horat |
          | Amy | Groshek |
          | Marco Antonio | Toscano Freire |
          | Sidik | Lepic |
          | Charles | Fulton |
          | Oren | Gerstner |
          | Tahir Javed | Awan |
          | shuvro | paul |
          | Leandro | Vieira de Souza |
          | Derick | Turner |
          | Manuel | Montoya |
          | Phil | Cross |
          | James | Brisland |
          | Paul | Vaughan |
          | Luiz Eduardo Laydner | Cruz |
          | Isaac | Marco Blancas |
          | Olga | Santos |
          | Chris | Wager |
          | Nguyen Minh | Duc |
          | Joey | Meece |
          | Muhammad | Sutiyadi |
          | genius | hu |
          | Juan Gabriel | Sáenz |
          | Eric | Villard |
          | Rhodry | Korb |
          | Amir | Elion |
          | Gabriel | Dias |
          | wong | lai leng |
          | ana | glez |
          | Mike | Waters |
          | Constantinos | Delistavrou |
          | jerome | mouneyrac |
          | william adolfo | urrea varon |
          | Jérôme | Charaoui |
          | Abdel Kawy | Abdel Hady |
          | Jonathon | Fowler |
          | Liang | Feng |
          | Ivan | Rodríguez López |
          | Helen | Chen |
          | Felipe | Cidade |
          | Eric | Massague |
          | David | Knight |
          | David | Windham |
          | Nic | Root |
          | Askar | Salimbaev |
          | Wojciech | Dobrowolski |
          | joao | rodrigues |
          | Dianne | Britton |
          | Décio Henrique Marques | Silva |
          | Iyappan | Krishnaswamy |
          | Grady | Laksmono |
          | yimy | jaramillo |
          | tamanna | saxena |
          | Raphael | Eidus |
          | Jennifer | Brooks |
          | Oriol | Aguilar Anguera |
          | The | King |
          | Tom | Lanyon |
          | Rafael | Bernini |
          | Huy | Hoang |
          | Brian | Jorgensen |
          | Julio | Monetti |
          | Björn | Kechel |
          | Mike | Skovgaard |
          | Thomás | Sieczkowski |
          | Sahl | Saad |
          | Vadim | Dvorovenko |
          | Nadia | Afrin |
          | สมจิน | เปียโคกสูง |
          | Matthieu | Nué |
          | Spencer | Creasey |
          | Michael | Aherne |
          | Sumon | Shahriar |
          | Jonathon | Hile |
          | new | smile |
          | christian | gonzalez oyanedel |
          | Roly | Vicaria |
          | Tim | Lock |
          | rashmi | sonar |
          | Yannis | T |
          | spirit | x |
          | Timothy | Allen |
          | Urso | Wieske |
          | Valdir | Leite |
          | Thomas | Leonard |
          | Jay | Knight |
          | bomb | f16 |
          | José Ricardo | Schnell |
          | murat | cekinmez |
          | John | Crepezzi |
          | Truong | Viet Hung |
          | Mahmud | Gobel |
          | justin | lee |
          | Dean | Lennard |
          | karima | kamin |
          | Marco | Calisti |
          | Kevin | Wiliarty |
          | Taras | Chaykivskyy |
          | 123flash | chat |
          | Rex | Lorenzo |
          | 胜利 | 程 |
          | chapa | goonatillaka |
          | Lucas | Schwochow |
          | Adonis P | Dutra |
          | reena | nagrale |
          | Henning | Bostelmann |
          | Manjunath | Kalburgi |
          | Manbeer | Makhloga |
          | Lucian | DiPeso |
          | Giridhar | S |
          | prakash | msamy |
          | Luke | Tucker |
          | Jason | Platts |
          | Cathal | O'Riordan |
          | Maydane | Okiye |
          | Oktawian | Wołków |
          | jaap | wietman |
          | Nitin | Yadav |
          | tarun | gulyani |
          | admin | admin |
          | Jessica | Puls |
          | Moodle | Bot |
          | Phong | Pham Duy |
          | Kris | Robinson |
          | son | hoyoung |
          | Wirianto | Djunaidi |
          | Paul | Charsley |
          | Samet | BAL |
          | Jonathan | Champ |
          | Ahmed | Nada |
          | alaa | anis |
          | Kenny | Tran |
          | Rajesh | Panwar |
          | Efe Cem | Kocabaş |
          | Jan | Miller |
          | Leo | Jackson |
          | Moushami | Rai |
          | Badrul | Mohamad |
          | Divya | muvvala |
          | marian | van de Venn |
          | Pablo | Ordonez |
          | Luís André | Oliveira |
          | Shyam Sunder Santoshi | Visamsetty |
          | triet | le minh |
          | Gerwood | Stewart |
          | rohit | jain |
          | Tõnis | Tartes |
          | Jaswinder | Singh |
          | joven | imperio |
          | Megan | Thomas |
          | Patrick | McNeill |
          | Daren | Chandisingh |
          | Steven | Delapeña lascano |
          | Danny | Wahl |
          | Michael | Clair |
          | John | Kelsh |
          | Nikolaos | Ioannou |
          | Huy | LM |
          | galuh | muntaz |
          | hon wai | lau |
          | Aaron | Wells |
          | tania | cando |
          | ramya | krishnan |
          | RICARDO | bittar |
          | Ajay | Patel |
          | Robert | Fahy |
          | Anna | Davis |
          | Mauro | Mazzieri |
          | luay | khrisat |
          | fatima zohra | elhlouli |
          | Martin | Musatov |
          | Diogo | Henrique |
          | Byeon | Jaehee |
          | Postgraduate | Administrator |
          | Cecil | Betros |
          | Paul | Nicholls |
          | Yang | Yang |
          | Nathan | Mares |
          | 송 | 주홍 |
          | Deepa | Narayanan |
          | Tukam | Dixon |
          | wuwuh | hartono |
          | Catherine | cifuentes |
          | Rodrigo | Nascentes |
          | Chris | Follin |
          | Tyler | Bannister |
          | waldo | villegas mendivil |
          | Haden | Fletcher |
          | Gilles-Philippe | Leblanc |
          | Diane | Villemure |
          | Sam | Hemelryk |
          | Evan | Irving-Pease |
          | Vignesh | E |
          | tumbur | josua |
          | Jason | Ilicic |
          | Jody | Steele |
          | Yousef | Sabbah |
          | Mayank | Gupta |
          | Anita | Mourya |
          | Mike | Holzer |
          | Asaf | Ohaion |
          | Alexander | Bias |
          | Jean-Philippe | Gaudreau |
          | Helmut | Irle |
          | ALHAMDULILLAH Osman | Mohiuddin |
          | Sagie | Maoz |
          | Ali | Ayaz |
          | nikhil | gupta |
          | Gayan | Lorenzu Hewa |
          | Eduardo | Pinto |
          | Adam | Olley |
          | Adiel | Ntuk |
          | Hugh | Davenport |
          | Weston | Dunn |
          | Tony | Levi |
          | liao | liefa |
          | Tu | Nguyen |
          | Matt (WCW) | Meisberger |
          | Christan | Ondevilla |
          | Tom | Cubanski |
          | Kirill | Astashov |
          | Teddy | Kasev |
          | Aleksey | Avdeev |
          | aries | andan |
          | Wiktor | Wandachowicz |
          | udhayakumar | R |
          | Raymond | Antonio |
          | Ulises | Martínez |
          | Valeriy | Streltsov |
          | Andrew | Davidson |
          | Igor | Sazonov |
          | David | Penner |
          | David Hai | Gootvilig |
          | Fábio | Souto |
          | Kanika | Goyal |
          | Paul | Verrall |
          | Juho | Viitasalo |
          | Iurii | Kucherov |
          | Barbara | Ramiro |
          | Ciaran | Irvine |
          | Yevhenii | Vlasenko |
          | Nick | Read |
          | Didier | Raboud |
          | Adrian | Fish |
          | Kyle | Temkin |
          +-------------------------+-----------------------------------------+
          326 rows in set (3.45 sec)
          {code} ]
          Hide
          Dan Poltawski added a comment -

          (Deleted some of my old comments to try and prevent confusion). With David, determined that we shouldn't be looking at the aliases. So I ran again now only looking at actual commits in moodle.git:

          Now, we remove 175 users who currently have access to the chat:

          -----------------------+----------------------+
          | firstname              | lastname             |
          +------------------------+----------------------+
          | Ling                   | Li                   |
          | Bob                    | Puffer               |
          | Jonathan               | Moore                |
          | Geoffrey               | Rowland              |
          | Étienne                | Rozé                 |
          | Erkki                  | Laaneoks             |
          | Borja                  | Rubio Reyes          |
          | Robert                 | Leskovar             |
          | Karen                  | Coyle                |
          | Troy                   | Williams             |
          | guy                    | thomas               |
          | Domenico               | Pontari              |
          | Ludo (Marc             | Alier)               |
          | Vasilis                | Daloukas             |
          | Scott                  | Wilson               |
          | James                  | Barrett              |
          | Anna                   | Vanova               |
          | Theodore               | Tzidamis             |
          | Paul                   | Edwards              |
          | Emanuel                | Gruengard            |
          | Richard                | Goddard              |
          | Daniel                 | Neis Araujo          |
          | Jasmin                 | Klindzic             |
          | Julian                 | Ridden               |
          | JG                     | G                    |
          | Živana                 | Komlenov             |
          | Artem                  | Andreev              |
          | Gilvan                 | Marques              |
          | antonio                | vilela               |
          | ferran                 | recio                |
          | Toni                   | Mas                  |
          | David                  | Castro               |
          | Mohamed                | Abdi                 |
          | Miroslav               | Fikar                |
          | Alex                   | Little               |
          | Matt                   | Campbell             |
          | Rashan                 | Anushka              |
          | Patrick                | Pollet               |
          | Ralf                   | Krause               |
          | Harsha                 | Balasooriya          |
          | James                  | Ballard              |
          | Finjon                 | Kiang                |
          | Bojan                  | Milosavljević        |
          | Gary                   | Anderson             |
          | Matt                   | Gibson               |
          | Davide                 | Cervone              |
          | Amr                    | Hourani              |
          | Jose'                  | Coelho               |
          | Alan                   | Carter               |
          | Marty                  | Jacobs               |
          | Rob                    | Byrd                 |
          | Alf Martin             | Johnsen              |
          | Alastair               | Hole                 |
          | John                   | Isner                |
          | Patrick                | Thibaudeau           |
          | Michael                | Spall                |
          | Bente                  | Olsen                |
          | John Harald            | Gartland             |
          | Charles                | Kelly                |
          | Robert                 | Russo                |
          | Susana                 | L.                   |
          | Andreas                | Söllei               |
          | Dr. Amitkumar          | Mali                 |
          | Akio                   | Ohnishi              |
          | Red                    | Morris               |
          | Mitja                  | Podreka              |
          | Sam                    | Test                 |
          | Ann                    | Adamcik              |
          | Sarveswaran            | Kengatharaiyer       |
          | Akinsaya               | Delamarre            |
          | Mike                   | Wilson               |
          | Peter                  | Chamberlin           |
          | Shahar                 | Dolev                |
          | Santiago               | Blanco               |
          | Arnis                  | Voitkans             |
          | David                  | Tong                 |
          | Malinda                | Siriwardana          |
          | Ted                    | Bowman               |
          | Jason                  | Hardin               |
          | Andrei                 | Băutu                |
          | Adriane                | Boyd                 |
          | Rajesh                 | Dharmalingam         |
          | Alan                   | Trick                |
          | Dean                   | Stringer             |
          | Kaleelur               | Rahuman              |
          | Süreç                  | Özcan                |
          | Sokhem                 | Khoem                |
          | Anastasios             | Pournias             |
          | Darryl                 | Pogue                |
          | Anna                   | Danielewska-Tułecka  |
          | William                | McGrath              |
          | Respondus              | Inc.                 |
          | Simon                  | Hanmer               |
          | Leif                   | Johnson              |
          | Aaron                  | Fulton               |
          | Jon                    | Skulski              |
          | Matteo                 | Savio                |
          | Emanuel                | Delgado              |
          | Gareth J               | Barnard              |
          | Alan                   | Barrett              |
          | Adam                   | Zapletal             |
          | Ian                    | MacDonald            |
          | Madhabendra            | Mandal               |
          | Marc                   | Grober               |
          | Paul                   | Dawson               |
          | Dakota                 | Duff                 |
          | Stanislav              | Tsymbalov            |
          | Laia                   | Subirats Maté        |
          | Barry                  | Oosthuizen           |
          | Nate                   | Baxley               |
          | Đại                    | Nguyễn Tấn           |
          | akshit                 | sharma               |
          | Mary                   | Cooch                |
          | Daniel                 | Servos               |
          | Karsten                | Jonas                |
          | Mike                   | Worth                |
          | Razib                  | Mustafiz             |
          | Niall                  | Barr                 |
          | Oscar                  | Sanchez              |
          | Daniel                 | Prieler              |
          | Ricardo                | Queirós              |
          | Kris                   | Stokking             |
          | Vlas                   | Voloshin             |
          | Javier                 | González González    |
          | Harmeet                | Saini                |
          | Eoin                   | Campbell             |
          | Sergey                 | Butakov              |
          | Ravishankar            | Somasundaram         |
          | Jordan                 | Tomkinson            |
          | Nuno                   | Barbosa              |
          | Mauro                  | Rondinelli           |
          | Faisal                 | Kaleem               |
          | Aled                   | Jones                |
          | Nick                   | Thompson             |
          | John                   | Tutchings            |
          | USHA                   | DEO                  |
          | Fabian                 | Gebert               |
          | Jonathan               | Doane                |
          | Pablo                  | Angulo               |
          | José                   | Cedeño               |
          | Frank                  | Wolf                 |
          | Mihai                  | Cotu                 |
          | Alexandru              | Diaconu              |
          | Peter                  | Tierney-Fife         |
          | Chiara                 | Fusaroli             |
          | pallavi                | maiya                |
          | Eric                   | Brisson              |
          | Gilbert                | Rehling              |
          | Adam                   | Schechter            |
          | Kostas                 | Georgakopoulos       |
          | Leo                    | Thiessen             |
          | Siau Meng              | Nyam                 |
          | Gregor                 | Gimmy                |
          | Alexander              | Blessing             |
          | Victor                 | Bautista             |
          | Rick                   | Guardia              |
          | HQ                     | Read Only            |
          | Federico               | Heinz                |
          | Thisum                 | Buddhika             |
          | Tenzin                 | Dendup               |
          | Brett                  | Wilkins              |
          | dan                    | attwood              |
          | Alex                   | Contis               |
          | Alejandro              | Michavila Pallarés   |
          | Jurij                  | Cizevskij            |
          | Ricky                  | Marcelin             |
          | Eric                   | Comte Marois         |
          | Thomas                 | Alsén                |
          | Adam                   | Lewera               |
          | Royal Roads University | Developer            |
          | Héctor                 | Menéndez             |
          | Balázs                 | Benedek              |
          | Yair                   | Spielmann            |
          | Bree                   | Vreedenburgh         |
          +------------------------+----------------------+
          174 rows in set (3.46 sec)
          

          And ahh this 150:

          mysql> SELECT firstname, lastname FROM user WHERE id IN (SELECT userid FROM cohort_members WHERE cohortid = 10 AND userid NOT IN (SELECT userid FROM cohort_members WHERE cohortid = 5));
          +----------------------+---------------+
          | firstname            | lastname      |
          +----------------------+---------------+
          | Hans                 | de Zwart      |
          | Thomas               | Robb          |
          | Ahmed                | Nabil         |
          | Holger               | Schadeck      |
          | Claudio              | Tavares       |
          | Antonio              | Navarro       |
          | Juraj                | Chlebec       |
          | Zhang                | dexuan        |
          | Set                  | Lonnert       |
          | Ray                  | Kingdon       |
          | Greg                 | Barnett       |
          | Michael              | Schneider     |
          | Istvan               | Bozsa         |
          | Scott                | Elliott       |
          | Paul                 | Shew          |
          | Palo                 | Jacko         |
          | Stig Bjarne          | Haugen        |
          | John                 | Gone          |
          | Zbigniew             | Fiedorowicz   |
          | Les                  | Kopari        |
          | Daniel               | Fetzer        |
          | Pablo                | Etcheverry    |
          | David                | Scotson       |
          | Anders               | Berggren      |
          | Dr. Ali              | Abureesh      |
          | Henrik               | Kaipe         |
          | Russell              | Jungwirth     |
          | Andrew               | Redkin        |
          | Christian            | Borowski      |
          | Williams             | Castillo      |
          | Thanh                | Le            |
          | Dan                  | Stowell       |
          | Daryl                | Hawes         |
          | Kristian             | Nielsen       |
          | André                | Krüger        |
          | Jan                  | Dierckx       |
          | Carsten              | Schmitz       |
          | Hung                 | Viet Nam      |
          | Markus               | Hagman        |
          | Enrique              | Castro        |
          | Ziba                 | Scott         |
          | Andreas              | Grabs         |
          | Girts                | Ozolins       |
          | Jeff                 | Graham        |
          | Brian                | King          |
          | Julian               | Sedding       |
          | dovix                | :)            |
          | Dave                 | Balch         |
          | romuald              | lorthioir     |
          | Aaron                | Spike         |
          | Ling                 | Li            |
          | Fei                  | Yang          |
          | Stephen              | Bourget       |
          | Andrew               | Ivanov        |
          | Lasha                | Altunashvili  |
          | Zhigang              | Sun           |
          | Myles                | Carrick       |
          | Patrick              | Li            |
          | Charles              | Severance     |
          | Tomaž                | Savodnik      |
          | Yu                   | Zhang         |
          | Vy-Shane             | Sin Fat       |
          | Takayuki             | ISHIKAWA      |
          | Sam                  | Chaffee       |
          | Eloys                | Lafuentes     |
          | Tom                  | Flannaghan    |
          | Michael              | Champanis     |
          | Vincenzo K.          | Marcovecchio  |
          | Ed                   | Coyne         |
          | Amy                  | Groshek       |
          | Charles              | Fulton        |
          | Derick               | Turner        |
          | James                | Brisland      |
          | Paul                 | Vaughan       |
          | Luiz Eduardo Laydner | Cruz          |
          | Isaac                | Marco Blancas |
          | Olga                 | Santos        |
          | Mike                 | Waters        |
          | jerome               | mouneyrac     |
          | Jonathon             | Fowler        |
          | Tom                  | Lanyon        |
          | Huy                  | Hoang         |
          | Brian                | Jorgensen     |
          | Vadim                | Dvorovenko    |
          | Michael              | Aherne        |
          | Tim                  | Lock          |
          | Timothy              | Allen         |
          | Jay                  | Knight        |
          | Dean                 | Lennard       |
          | Kevin                | Wiliarty      |
          | Rex                  | Lorenzo       |
          | Henning              | Bostelmann    |
          | Luke                 | Tucker        |
          | Jason                | Platts        |
          | Cathal               | O'Riordan     |
          | Moodle               | Bot           |
          | Wirianto             | Djunaidi      |
          | Paul                 | Charsley      |
          | Jonathan             | Champ         |
          | Gerwood              | Stewart       |
          | Tõnis                | Tartes        |
          | Patrick              | McNeill       |
          | Daren                | Chandisingh   |
          | Danny                | Wahl          |
          | John                 | Kelsh         |
          | Aaron                | Wells         |
          | Paul                 | Nicholls      |
          | Yang                 | Yang          |
          | Nathan               | Mares         |
          | Deepa                | Narayanan     |
          | Chris                | Follin        |
          | Tyler                | Bannister     |
          | Gilles-Philippe      | Leblanc       |
          | Diane                | Villemure     |
          | Evan                 | Irving-Pease  |
          | Jason                | Ilicic        |
          | Jody                 | Steele        |
          | Mayank               | Gupta         |
          | Alexander            | Bias          |
          | Jean-Philippe        | Gaudreau      |
          | Sagie                | Maoz          |
          | nikhil               | gupta         |
          | Eduardo              | Pinto         |
          | Adam                 | Olley         |
          | Hugh                 | Davenport     |
          | Tony                 | Levi          |
          | Matt (WCW)           | Meisberger    |
          | Tom                  | Cubanski      |
          | Kirill               | Astashov      |
          | Aleksey              | Avdeev        |
          | Wiktor               | Wandachowicz  |
          | Raymond              | Antonio       |
          | Valeriy              | Streltsov     |
          | Andrew               | Davidson      |
          | Igor                 | Sazonov       |
          | David                | Penner        |
          | David Hai            | Gootvilig     |
          | Fábio                | Souto         |
          | Kanika               | Goyal         |
          | Paul                 | Verrall       |
          | Juho                 | Viitasalo     |
          | Iurii                | Kucherov      |
          | Barbara              | Ramiro        |
          | Ciaran               | Irvine        |
          | Yevhenii             | Vlasenko      |
          | Nick                 | Read          |
          | Didier               | Raboud        |
          | Adrian               | Fish          |
          | Kyle                 | Temkin        |
          +----------------------+---------------+
          149 rows in set (3.57 sec)
          
          Show
          Dan Poltawski added a comment - (Deleted some of my old comments to try and prevent confusion). With David, determined that we shouldn't be looking at the aliases. So I ran again now only looking at actual commits in moodle.git: Now, we remove 175 users who currently have access to the chat: -----------------------+----------------------+ | firstname | lastname | +------------------------+----------------------+ | Ling | Li | | Bob | Puffer | | Jonathan | Moore | | Geoffrey | Rowland | | Étienne | Rozé | | Erkki | Laaneoks | | Borja | Rubio Reyes | | Robert | Leskovar | | Karen | Coyle | | Troy | Williams | | guy | thomas | | Domenico | Pontari | | Ludo (Marc | Alier) | | Vasilis | Daloukas | | Scott | Wilson | | James | Barrett | | Anna | Vanova | | Theodore | Tzidamis | | Paul | Edwards | | Emanuel | Gruengard | | Richard | Goddard | | Daniel | Neis Araujo | | Jasmin | Klindzic | | Julian | Ridden | | JG | G | | Živana | Komlenov | | Artem | Andreev | | Gilvan | Marques | | antonio | vilela | | ferran | recio | | Toni | Mas | | David | Castro | | Mohamed | Abdi | | Miroslav | Fikar | | Alex | Little | | Matt | Campbell | | Rashan | Anushka | | Patrick | Pollet | | Ralf | Krause | | Harsha | Balasooriya | | James | Ballard | | Finjon | Kiang | | Bojan | Milosavljević | | Gary | Anderson | | Matt | Gibson | | Davide | Cervone | | Amr | Hourani | | Jose' | Coelho | | Alan | Carter | | Marty | Jacobs | | Rob | Byrd | | Alf Martin | Johnsen | | Alastair | Hole | | John | Isner | | Patrick | Thibaudeau | | Michael | Spall | | Bente | Olsen | | John Harald | Gartland | | Charles | Kelly | | Robert | Russo | | Susana | L. | | Andreas | Söllei | | Dr. Amitkumar | Mali | | Akio | Ohnishi | | Red | Morris | | Mitja | Podreka | | Sam | Test | | Ann | Adamcik | | Sarveswaran | Kengatharaiyer | | Akinsaya | Delamarre | | Mike | Wilson | | Peter | Chamberlin | | Shahar | Dolev | | Santiago | Blanco | | Arnis | Voitkans | | David | Tong | | Malinda | Siriwardana | | Ted | Bowman | | Jason | Hardin | | Andrei | Băutu | | Adriane | Boyd | | Rajesh | Dharmalingam | | Alan | Trick | | Dean | Stringer | | Kaleelur | Rahuman | | Süreç | Özcan | | Sokhem | Khoem | | Anastasios | Pournias | | Darryl | Pogue | | Anna | Danielewska-Tułecka | | William | McGrath | | Respondus | Inc. | | Simon | Hanmer | | Leif | Johnson | | Aaron | Fulton | | Jon | Skulski | | Matteo | Savio | | Emanuel | Delgado | | Gareth J | Barnard | | Alan | Barrett | | Adam | Zapletal | | Ian | MacDonald | | Madhabendra | Mandal | | Marc | Grober | | Paul | Dawson | | Dakota | Duff | | Stanislav | Tsymbalov | | Laia | Subirats Maté | | Barry | Oosthuizen | | Nate | Baxley | | Đại | Nguyễn Tấn | | akshit | sharma | | Mary | Cooch | | Daniel | Servos | | Karsten | Jonas | | Mike | Worth | | Razib | Mustafiz | | Niall | Barr | | Oscar | Sanchez | | Daniel | Prieler | | Ricardo | Queirós | | Kris | Stokking | | Vlas | Voloshin | | Javier | González González | | Harmeet | Saini | | Eoin | Campbell | | Sergey | Butakov | | Ravishankar | Somasundaram | | Jordan | Tomkinson | | Nuno | Barbosa | | Mauro | Rondinelli | | Faisal | Kaleem | | Aled | Jones | | Nick | Thompson | | John | Tutchings | | USHA | DEO | | Fabian | Gebert | | Jonathan | Doane | | Pablo | Angulo | | José | Cedeño | | Frank | Wolf | | Mihai | Cotu | | Alexandru | Diaconu | | Peter | Tierney-Fife | | Chiara | Fusaroli | | pallavi | maiya | | Eric | Brisson | | Gilbert | Rehling | | Adam | Schechter | | Kostas | Georgakopoulos | | Leo | Thiessen | | Siau Meng | Nyam | | Gregor | Gimmy | | Alexander | Blessing | | Victor | Bautista | | Rick | Guardia | | HQ | Read Only | | Federico | Heinz | | Thisum | Buddhika | | Tenzin | Dendup | | Brett | Wilkins | | dan | attwood | | Alex | Contis | | Alejandro | Michavila Pallarés | | Jurij | Cizevskij | | Ricky | Marcelin | | Eric | Comte Marois | | Thomas | Alsén | | Adam | Lewera | | Royal Roads University | Developer | | Héctor | Menéndez | | Balázs | Benedek | | Yair | Spielmann | | Bree | Vreedenburgh | +------------------------+----------------------+ 174 rows in set (3.46 sec) And ahh this 150: mysql> SELECT firstname, lastname FROM user WHERE id IN (SELECT userid FROM cohort_members WHERE cohortid = 10 AND userid NOT IN (SELECT userid FROM cohort_members WHERE cohortid = 5)); +----------------------+---------------+ | firstname | lastname | +----------------------+---------------+ | Hans | de Zwart | | Thomas | Robb | | Ahmed | Nabil | | Holger | Schadeck | | Claudio | Tavares | | Antonio | Navarro | | Juraj | Chlebec | | Zhang | dexuan | | Set | Lonnert | | Ray | Kingdon | | Greg | Barnett | | Michael | Schneider | | Istvan | Bozsa | | Scott | Elliott | | Paul | Shew | | Palo | Jacko | | Stig Bjarne | Haugen | | John | Gone | | Zbigniew | Fiedorowicz | | Les | Kopari | | Daniel | Fetzer | | Pablo | Etcheverry | | David | Scotson | | Anders | Berggren | | Dr. Ali | Abureesh | | Henrik | Kaipe | | Russell | Jungwirth | | Andrew | Redkin | | Christian | Borowski | | Williams | Castillo | | Thanh | Le | | Dan | Stowell | | Daryl | Hawes | | Kristian | Nielsen | | André | Krüger | | Jan | Dierckx | | Carsten | Schmitz | | Hung | Viet Nam | | Markus | Hagman | | Enrique | Castro | | Ziba | Scott | | Andreas | Grabs | | Girts | Ozolins | | Jeff | Graham | | Brian | King | | Julian | Sedding | | dovix | :) | | Dave | Balch | | romuald | lorthioir | | Aaron | Spike | | Ling | Li | | Fei | Yang | | Stephen | Bourget | | Andrew | Ivanov | | Lasha | Altunashvili | | Zhigang | Sun | | Myles | Carrick | | Patrick | Li | | Charles | Severance | | Tomaž | Savodnik | | Yu | Zhang | | Vy-Shane | Sin Fat | | Takayuki | ISHIKAWA | | Sam | Chaffee | | Eloys | Lafuentes | | Tom | Flannaghan | | Michael | Champanis | | Vincenzo K. | Marcovecchio | | Ed | Coyne | | Amy | Groshek | | Charles | Fulton | | Derick | Turner | | James | Brisland | | Paul | Vaughan | | Luiz Eduardo Laydner | Cruz | | Isaac | Marco Blancas | | Olga | Santos | | Mike | Waters | | jerome | mouneyrac | | Jonathon | Fowler | | Tom | Lanyon | | Huy | Hoang | | Brian | Jorgensen | | Vadim | Dvorovenko | | Michael | Aherne | | Tim | Lock | | Timothy | Allen | | Jay | Knight | | Dean | Lennard | | Kevin | Wiliarty | | Rex | Lorenzo | | Henning | Bostelmann | | Luke | Tucker | | Jason | Platts | | Cathal | O'Riordan | | Moodle | Bot | | Wirianto | Djunaidi | | Paul | Charsley | | Jonathan | Champ | | Gerwood | Stewart | | Tõnis | Tartes | | Patrick | McNeill | | Daren | Chandisingh | | Danny | Wahl | | John | Kelsh | | Aaron | Wells | | Paul | Nicholls | | Yang | Yang | | Nathan | Mares | | Deepa | Narayanan | | Chris | Follin | | Tyler | Bannister | | Gilles-Philippe | Leblanc | | Diane | Villemure | | Evan | Irving-Pease | | Jason | Ilicic | | Jody | Steele | | Mayank | Gupta | | Alexander | Bias | | Jean-Philippe | Gaudreau | | Sagie | Maoz | | nikhil | gupta | | Eduardo | Pinto | | Adam | Olley | | Hugh | Davenport | | Tony | Levi | | Matt (WCW) | Meisberger | | Tom | Cubanski | | Kirill | Astashov | | Aleksey | Avdeev | | Wiktor | Wandachowicz | | Raymond | Antonio | | Valeriy | Streltsov | | Andrew | Davidson | | Igor | Sazonov | | David | Penner | | David Hai | Gootvilig | | Fábio | Souto | | Kanika | Goyal | | Paul | Verrall | | Juho | Viitasalo | | Iurii | Kucherov | | Barbara | Ramiro | | Ciaran | Irvine | | Yevhenii | Vlasenko | | Nick | Read | | Didier | Raboud | | Adrian | Fish | | Kyle | Temkin | +----------------------+---------------+ 149 rows in set (3.57 sec)
          Hide
          Dan Poltawski added a comment -

          Hi Helen,

          We can deploy this when necesary - just wondering what the best thing to do will be regarding the people who are in the chat group but won't be allowed any more a lot were old contrib developers (who may not even know about the chat of course).

          Show
          Dan Poltawski added a comment - Hi Helen, We can deploy this when necesary - just wondering what the best thing to do will be regarding the people who are in the chat group but won't be allowed any more a lot were old contrib developers (who may not even know about the chat of course).
          Hide
          Helen Foster added a comment -

          Hi Dan,

          I think you can deploy the plugin straight away. I have created a role on moodle.org for giving people access to the chat history if they are not members of the developer cohort. (Thinking of Mary and anyone else who asks and has a good reason.)

          Show
          Helen Foster added a comment - Hi Dan, I think you can deploy the plugin straight away. I have created a role on moodle.org for giving people access to the chat history if they are not members of the developer cohort. (Thinking of Mary and anyone else who asks and has a good reason.)
          Hide
          Dan Poltawski added a comment -

          OK done, i've deployed this and switched the developer chat plugin to use this cohort. You can use this cohort to populate the 'core developers' group in all the courses now too.

          I've set it up to sync at the end of the the other developer plugin jobs.

          Show
          Dan Poltawski added a comment - OK done, i've deployed this and switched the developer chat plugin to use this cohort. You can use this cohort to populate the 'core developers' group in all the courses now too. I've set it up to sync at the end of the the other developer plugin jobs.
          Dan Poltawski made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Martin Dougiamas made changes -
          Workflow jira [ 104094 ] SITES Full Workflow [ 126568 ]
          Martin Dougiamas made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development