Details

      Description

      http://docs.moodle.org/dev is missing a navigation bar, also http://docs.moodle.org/19/en/ and all wikis listed on http://docs.moodle.org/overview/ apart from 20/en, 21/en, 22/en and 20/de which have a special nav bar generated by stuff in the wiki page.

      The missing navigation bar was something like (can't remember exactly):

      <a href="http://docs.moodle.org/overview/">Moodle Docs</a> > <a href="http://docs.moodle.org/19/en/Main_page">English</a> > Page name

        Gliffy Diagrams

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Helen,

          Is this navtrail stuff something you enable in wiki templates? We need to make sure that we don't show both the navigation bar and this navtrail?

          I think I see this in the code, its preventing from running at the moment for all wikis so we need to decide when to show it and when not to:

          code
          /*
          echo '<ul>';
          echo '<li class="first"><a href="http://moodle.org">Home</a></li>';
          echo '<li class="first"><span class="accesshide " >/ </span><span class="arrow sep">►</span> <a href="/overview/">Moodle Docs</a></li>';
          echo '<li class="first"><span class="accesshide " >/ </span><span class="arrow sep">►</span> <a href="'.htmlspecialchars($scriptpath).'/">'.$wgLanguageName.'</a></li>';
          echo '<li class="first"><span class="accesshide " >/ </span><span class="arrow sep">►</span> '.$title.'</li>';
          echo '</ul>';
          */
          code

          Show
          Dan Poltawski added a comment - Hi Helen, Is this navtrail stuff something you enable in wiki templates? We need to make sure that we don't show both the navigation bar and this navtrail? I think I see this in the code, its preventing from running at the moment for all wikis so we need to decide when to show it and when not to: code /* echo '<ul>'; echo '<li class="first"><a href="http://moodle.org">Home</a></li>'; echo '<li class="first"><span class="accesshide " >/ </span><span class="arrow sep">►</span> <a href="/overview/">Moodle Docs</a></li>'; echo '<li class="first"><span class="accesshide " >/ </span><span class="arrow sep">►</span> <a href="'.htmlspecialchars($scriptpath).'/">'.$wgLanguageName.'</a></li>'; echo '<li class="first"><span class="accesshide " >/ </span><span class="arrow sep">►</span> '.$title.'</li>'; echo '</ul>'; */ code
          Hide
          Helen Foster added a comment -

          Hi Dan,

          Yes, the navtrail stuff is generated by wiki templates e.g. http://docs.moodle.org/22/en/index.php?title=Template:Managing_a_Moodle_course&action=edit includes

          <div class="navtrail">[[Main page]] ► [[Managing a Moodle course]] ► [[{{PAGENAME}}]]</div>

          This is the case for 20/en, 21/en, 22/en and 20/de only. All other wikis need it re-adding I guess using the code you mention.

          Show
          Helen Foster added a comment - Hi Dan, Yes, the navtrail stuff is generated by wiki templates e.g. http://docs.moodle.org/22/en/index.php?title=Template:Managing_a_Moodle_course&action=edit includes <div class="navtrail">[ [Main page] ] ► [ [Managing a Moodle course] ] ► [ [{{PAGENAME}}] ]</div> This is the case for 20/en, 21/en, 22/en and 20/de only. All other wikis need it re-adding I guess using the code you mention.
          Hide
          Dan Poltawski added a comment -

          Hi Helen,

          I've fixed this, now I will show the nav bar for any non 20,21,22,23,24 wikis.

          Dan

          Show
          Dan Poltawski added a comment - Hi Helen, I've fixed this, now I will show the nav bar for any non 20,21,22,23,24 wikis. Dan
          Hide
          Helen Foster added a comment -

          Thanks a lot Dan, I've just looked through all the wikis listed on http://docs.moodle.org/overview/ and found each wiki to have a navigation bar - perfect!

          Show
          Helen Foster added a comment - Thanks a lot Dan, I've just looked through all the wikis listed on http://docs.moodle.org/overview/ and found each wiki to have a navigation bar - perfect!
          Hide
          David Mudrak added a comment -

          For the record, I will need to improve this solution a bit yet. While working on MDLSITE-2531, I realized that at a page http://docs.moodle.org/2x/ca/ we now have both navigation bars displayed (which is what Dan Poltawski was afraid of). This is caused by the fact that 1) the current theme does not expect any /2x page having the navtrail thing but 2) 2x/ca/ was created as a copy of 24/en/ so it has it.

          I will discuss with Helen how to address this.

          Show
          David Mudrak added a comment - For the record, I will need to improve this solution a bit yet. While working on MDLSITE-2531 , I realized that at a page http://docs.moodle.org/2x/ca/ we now have both navigation bars displayed (which is what Dan Poltawski was afraid of). This is caused by the fact that 1) the current theme does not expect any /2x page having the navtrail thing but 2) 2x/ca/ was created as a copy of 24/en/ so it has it. I will discuss with Helen how to address this.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development