Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Component/s: moodle.org
    • Labels:
      None

      Description

      1. Fix error when attempting to access scales in certain courses e.g. http://moodle.org/grade/edit/scale/index.php?id=20
      2. Delete all unused standard and custom scales

        Gliffy Diagrams

          Activity

          Hide
          Helen Foster added a comment -

          As mentioned in the moodle.org meeting, let's keep the social forum cool scale.

          Show
          Helen Foster added a comment - As mentioned in the moodle.org meeting, let's keep the social forum cool scale.
          Hide
          Dan Poltawski added a comment -

          Ah, the error I think is related to: MDLSITE-1913

          Show
          Dan Poltawski added a comment - Ah, the error I think is related to: MDLSITE-1913
          Hide
          Dan Poltawski added a comment -

          So, are we going to use the english word 'Useful' for all of these??

          Show
          Dan Poltawski added a comment - So, are we going to use the english word 'Useful' for all of these??
          Hide
          Helen Foster added a comment -

          "So, are we going to use the english word 'Useful' for all of these??" - please see my comment in MDLSITE-1877.

          I created this issue partly because I noticed tons of scales which can't be deleted via the UI but don't appear to be used anywhere.

          Show
          Helen Foster added a comment - "So, are we going to use the english word 'Useful' for all of these??" - please see my comment in MDLSITE-1877 . I created this issue partly because I noticed tons of scales which can't be deleted via the UI but don't appear to be used anywhere.
          Hide
          Dan Poltawski added a comment -

          I have hidden the cvsadmin module for now, which fixes 1. (and properly fixed by removing it all together in MDLSITE-1189)

          Show
          Dan Poltawski added a comment - I have hidden the cvsadmin module for now, which fixes 1. (and properly fixed by removing it all together in MDLSITE-1189 )
          Hide
          Dan Poltawski added a comment -

          Here are is where a lot of the scales are used:

          mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 3;
          ----------------------------------------+

          courseid itemtype itemmodule iteminstance

          ----------------------------------------+

          18 mod forum 319
          30 mod glossary 23
          30 mod assign 21
          30 mod assignment 340
          31 mod forum 292
          34 mod forum 419
          44 mod forum 606
          44 mod forum 655
          26 mod forum 228
          26 mod forum 229
          29 mod forum 346
          15 mod forum 481
          29 mod forum 564
          29 mod forum 591
          998 mod forum 979

          ----------------------------------------+
          15 rows in set (0.00 sec)

          mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 21;
          ----------------------------------------+

          courseid itemtype itemmodule iteminstance

          ----------------------------------------+

          37 mod forum 443

          ----------------------------------------+
          1 row in set (0.00 sec)

          mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 22;
          ----------------------------------------+

          courseid itemtype itemmodule iteminstance

          ----------------------------------------+

          31 mod forum 497
          37 mod forum 664
          37 mod forum 448
          11 mod data 42

          ----------------------------------------+
          4 rows in set (0.00 sec)

          mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 33;
          ----------------------------------------+

          courseid itemtype itemmodule iteminstance

          ----------------------------------------+

          21 mod forum 615
          21 mod forum 929
          31 mod forum 596
          31 mod forum 538
          31 mod forum 535
          31 mod forum 586
          31 mod forum 590
          40 mod forum 551
          40 mod forum 552
          40 mod forum 553
          40 mod forum 935
          41 mod forum 530
          43 mod forum 641
          44 mod forum 594
          44 mod forum 889
          44 mod forum 878
          44 mod forum 670
          44 mod forum 611
          44 mod forum 632
          44 mod forum 640
          44 mod forum 642
          44 mod forum 657
          44 mod forum 660
          44 mod forum 659
          44 mod forum 663
          44 mod forum 669
          46 mod forum 628
          46 mod forum 665
          49 mod forum 749
          49 mod forum 750
          49 mod forum 751
          49 mod forum 752
          49 mod forum 776
          49 mod forum 819
          49 mod forum 763
          49 mod forum 753
          49 mod forum 754
          49 mod forum 764
          49 mod forum 760
          49 mod forum 755
          49 mod forum 756
          49 mod forum 758
          49 mod forum 757
          29 mod forum 579
          29 mod forum 577
          29 mod forum 576
          29 mod forum 575
          29 mod forum 574
          29 mod forum 573
          29 mod forum 572
          29 mod forum 571
          29 mod forum 570
          29 mod forum 569
          29 mod forum 568
          51 mod forum 803
          51 mod forum 779
          51 mod forum 780
          51 mod forum 781
          51 mod forum 788
          51 mod forum 792
          51 mod forum 793
          51 mod forum 794
          51 mod forum 795
          51 mod forum 796
          51 mod forum 797
          46 mod forum 876
          53 mod forum 926

          ----------------------------------------+
          67 rows in set (0.01 sec)

          mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 54;
          ----------------------------------------+

          courseid itemtype itemmodule iteminstance

          ----------------------------------------+

          24 mod forum 700
          24 mod forum 698
          24 mod forum 694

          ----------------------------------------+
          3 rows in set (0.00 sec)

          mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 103;
          ----------------------------------------+

          courseid itemtype itemmodule iteminstance

          ----------------------------------------+

          32 mod forum 1116

          ----------------------------------------+
          1 row in set (0.00 sec)

          Show
          Dan Poltawski added a comment - Here are is where a lot of the scales are used: mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 3; --------- -------- ---------- -------------+ courseid itemtype itemmodule iteminstance --------- -------- ---------- -------------+ 18 mod forum 319 30 mod glossary 23 30 mod assign 21 30 mod assignment 340 31 mod forum 292 34 mod forum 419 44 mod forum 606 44 mod forum 655 26 mod forum 228 26 mod forum 229 29 mod forum 346 15 mod forum 481 29 mod forum 564 29 mod forum 591 998 mod forum 979 --------- -------- ---------- -------------+ 15 rows in set (0.00 sec) mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 21; --------- -------- ---------- -------------+ courseid itemtype itemmodule iteminstance --------- -------- ---------- -------------+ 37 mod forum 443 --------- -------- ---------- -------------+ 1 row in set (0.00 sec) mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 22; --------- -------- ---------- -------------+ courseid itemtype itemmodule iteminstance --------- -------- ---------- -------------+ 31 mod forum 497 37 mod forum 664 37 mod forum 448 11 mod data 42 --------- -------- ---------- -------------+ 4 rows in set (0.00 sec) mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 33; --------- -------- ---------- -------------+ courseid itemtype itemmodule iteminstance --------- -------- ---------- -------------+ 21 mod forum 615 21 mod forum 929 31 mod forum 596 31 mod forum 538 31 mod forum 535 31 mod forum 586 31 mod forum 590 40 mod forum 551 40 mod forum 552 40 mod forum 553 40 mod forum 935 41 mod forum 530 43 mod forum 641 44 mod forum 594 44 mod forum 889 44 mod forum 878 44 mod forum 670 44 mod forum 611 44 mod forum 632 44 mod forum 640 44 mod forum 642 44 mod forum 657 44 mod forum 660 44 mod forum 659 44 mod forum 663 44 mod forum 669 46 mod forum 628 46 mod forum 665 49 mod forum 749 49 mod forum 750 49 mod forum 751 49 mod forum 752 49 mod forum 776 49 mod forum 819 49 mod forum 763 49 mod forum 753 49 mod forum 754 49 mod forum 764 49 mod forum 760 49 mod forum 755 49 mod forum 756 49 mod forum 758 49 mod forum 757 29 mod forum 579 29 mod forum 577 29 mod forum 576 29 mod forum 575 29 mod forum 574 29 mod forum 573 29 mod forum 572 29 mod forum 571 29 mod forum 570 29 mod forum 569 29 mod forum 568 51 mod forum 803 51 mod forum 779 51 mod forum 780 51 mod forum 781 51 mod forum 788 51 mod forum 792 51 mod forum 793 51 mod forum 794 51 mod forum 795 51 mod forum 796 51 mod forum 797 46 mod forum 876 53 mod forum 926 --------- -------- ---------- -------------+ 67 rows in set (0.01 sec) mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 54; --------- -------- ---------- -------------+ courseid itemtype itemmodule iteminstance --------- -------- ---------- -------------+ 24 mod forum 700 24 mod forum 698 24 mod forum 694 --------- -------- ---------- -------------+ 3 rows in set (0.00 sec) mysql> select distinct courseid, itemtype, itemmodule, iteminstance from grade_items where scaleid = 103; --------- -------- ---------- -------------+ courseid itemtype itemmodule iteminstance --------- -------- ---------- -------------+ 32 mod forum 1116 --------- -------- ---------- -------------+ 1 row in set (0.00 sec)
          Hide
          Helen Foster added a comment -

          Thanks Dan for fixing the scales error and for finding out where all the scales are used. I've investigated a few cases as follows:

          http://clone.moodle.org/mod/forum/view.php?f=319 uses the Satisfactory scale - Seems odd using a scale in English in a German course. I guess we'd need to ask a course facilitator before removing it.

          http://clone.moodle.org/mod/forum/view.php?f=292 - Very old forum, I set the aggregate type to no ratings

          http://clone.moodle.org/mod/forum/view.php?f=443 - Chosen as it's the only activity using scaleid = 21, turns out that the forum is in an archived course, I set the aggregate type to no ratings and then tried to delete the scale but couldn't find it listed as a custom or standard scale. Hmm, it seems that the scale 'Vias de conocimiento separadas y conectadas' is a translation of the separate and connected ways of knowing scale.

          http://clone.moodle.org/mod/forum/view.php?f=1116 - Uses an excellent/very poor (5 point) standard scale.

          On reflection, I'm wondering whether there is actually any need to tidy up the scales on moodle.org if they are used somewhere?

          Perhaps I could just remove scales from activities in archived courses and then delete them if they're not used elsewhere, or is it not really necessary?

          Perhaps the standard scales in other languages e.g. Áóäüòå áåñïðèñòðàñòíûì should be converted to custom scales to avoid them appearing everywhere?

          Show
          Helen Foster added a comment - Thanks Dan for fixing the scales error and for finding out where all the scales are used. I've investigated a few cases as follows: http://clone.moodle.org/mod/forum/view.php?f=319 uses the Satisfactory scale - Seems odd using a scale in English in a German course. I guess we'd need to ask a course facilitator before removing it. http://clone.moodle.org/mod/forum/view.php?f=292 - Very old forum, I set the aggregate type to no ratings http://clone.moodle.org/mod/forum/view.php?f=443 - Chosen as it's the only activity using scaleid = 21, turns out that the forum is in an archived course, I set the aggregate type to no ratings and then tried to delete the scale but couldn't find it listed as a custom or standard scale. Hmm, it seems that the scale 'Vias de conocimiento separadas y conectadas' is a translation of the separate and connected ways of knowing scale. http://clone.moodle.org/mod/forum/view.php?f=1116 - Uses an excellent/very poor (5 point) standard scale. On reflection, I'm wondering whether there is actually any need to tidy up the scales on moodle.org if they are used somewhere? Perhaps I could just remove scales from activities in archived courses and then delete them if they're not used elsewhere, or is it not really necessary? Perhaps the standard scales in other languages e.g. Áóäüòå áåñïðèñòðàñòíûì should be converted to custom scales to avoid them appearing everywhere?
          Hide
          Helen Foster added a comment -

          Marking as resolved, since the error message has been fixed and it seems there are no unused scales. We can always create a new issue if further scales clean-up work is deemed necessary.

          Show
          Helen Foster added a comment - Marking as resolved, since the error message has been fixed and it seems there are no unused scales. We can always create a new issue if further scales clean-up work is deemed necessary.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development