Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Duplicate
    • Component/s: moodle.org
    • Labels:
      None

      Description

      This issue is about thread subscriptions for moodle.org. Note that this might or may not be distinct for a 'moodle core' solution (I think that forumng is the most promising long-term solution).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Notes about forum subscription plugin from Juan:

              Nice hack, extends navigation to add JS into the menu, so doesn't need to touch core at all!

              • Note though that this manually inserts 'YUI tree html' by hand, and looks likely to break in changes with yui/themes etc. Its fragile.
              • Performance impact of that could be something worth considering because it has to check if forum exists, capabilites etc etc in the JS, even though this is probably already known by moodle itself. This is a bit of a limitation because of the need for the 'hack'.

              Also, its a major deficiency that it is completely indepdent from existing forum subscriptions. So:

              • If you use digests, you'll get two digests - the current forum subscription digests and the 'thread digest', maybe with some of the same forum posts..
              • If you don't use digests you'll get two emails about the same thread if subscribed to thread and forum.
              • There are two bits of fairly identical code, the core forum code and this plugin. The logic looks like it is basically copied from core, but that core logic is horribly complex, so we have that complexity in two places.

              In summary, I think this solution would be a half-baked solution for people who use traditional subscriptions and thread subscriptions at the same time in the present state. i.e. most users on moodle.org...

              I think we'd need to really look at the forum emailing code in the existing and new code to see how these interact.

              Show
              poltawski Dan Poltawski added a comment - Notes about forum subscription plugin from Juan: Nice hack, extends navigation to add JS into the menu, so doesn't need to touch core at all! Note though that this manually inserts 'YUI tree html' by hand, and looks likely to break in changes with yui/themes etc. Its fragile. Performance impact of that could be something worth considering because it has to check if forum exists, capabilites etc etc in the JS, even though this is probably already known by moodle itself. This is a bit of a limitation because of the need for the 'hack'. Also, its a major deficiency that it is completely indepdent from existing forum subscriptions. So: If you use digests, you'll get two digests - the current forum subscription digests and the 'thread digest', maybe with some of the same forum posts.. If you don't use digests you'll get two emails about the same thread if subscribed to thread and forum. There are two bits of fairly identical code, the core forum code and this plugin. The logic looks like it is basically copied from core, but that core logic is horribly complex, so we have that complexity in two places. In summary, I think this solution would be a half-baked solution for people who use traditional subscriptions and thread subscriptions at the same time in the present state. i.e. most users on moodle.org... I think we'd need to really look at the forum emailing code in the existing and new code to see how these interact.
              Hide
              poltawski Dan Poltawski added a comment -

              I should also mention that it didn't work for me and I had to change some code to get it to work, so this existing plugin probably isn't 'moodle.org ready'

              The alternative 'short term' solution would be to integrate the concepts into the existing forum emailing code. To some extent, the most complex part of this is creating an extensive test suite for this. Its a complex beast, but with that then I think this can be achieved.

              Show
              poltawski Dan Poltawski added a comment - I should also mention that it didn't work for me and I had to change some code to get it to work, so this existing plugin probably isn't 'moodle.org ready' The alternative 'short term' solution would be to integrate the concepts into the existing forum emailing code. To some extent, the most complex part of this is creating an extensive test suite for this. Its a complex beast, but with that then I think this can be achieved.
              Hide
              derekcx Derek Chirnside added a comment -

              Dan, Why not just install ForumNG in Moodle.org?

              I can surmise lots of reasons: code, policy, priorities etc, I was just curious.
              AKAIK it is a separate plugin.

              -Derek

              Show
              derekcx Derek Chirnside added a comment - Dan, Why not just install ForumNG in Moodle.org? I can surmise lots of reasons: code, policy, priorities etc, I was just curious. AKAIK it is a separate plugin. -Derek
              Hide
              poltawski Dan Poltawski added a comment -

              Well, we'd need to migrate the forums and test its all working - that is a nontrivial task!

              Show
              poltawski Dan Poltawski added a comment - Well, we'd need to migrate the forums and test its all working - that is a nontrivial task!
              Hide
              dougiamas Martin Dougiamas added a comment -

              Looking at Advanced Forums from Moodlerooms for this.

              Show
              dougiamas Martin Dougiamas added a comment - Looking at Advanced Forums from Moodlerooms for this.
              Hide
              tsala Helen Foster added a comment -

              Dan, just wondering whether it's really feasible to come up with a discussion subscription solution for moodle.org only, or whether we should wait patiently for the feature to be added to core?

              Show
              tsala Helen Foster added a comment - Dan, just wondering whether it's really feasible to come up with a discussion subscription solution for moodle.org only, or whether we should wait patiently for the feature to be added to core?
              Hide
              poltawski Dan Poltawski added a comment -

              Closing as fixed by MDL-1626

              Show
              poltawski Dan Poltawski added a comment - Closing as fixed by MDL-1626

                People

                • Votes:
                  6 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: