Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Component/s: moodle.org
    • Labels:
      None
    • Rank:
      46410

      Description

        Activity

        Hide
        Mary Cooch added a comment -

        Was this an oversight or was it deliberate? I am just wondering as I really like the courses dropdown at the top but I wondered if it was meant to act the same as the new navigation block My courses setting? (which is taking some getting used to, but I understand the need for it)

        Show
        Mary Cooch added a comment - Was this an oversight or was it deliberate? I am just wondering as I really like the courses dropdown at the top but I wondered if it was meant to act the same as the new navigation block My courses setting? (which is taking some getting used to, but I understand the need for it)
        Hide
        Dan Poltawski added a comment -

        Looking..

        Show
        Dan Poltawski added a comment - Looking..
        Hide
        Dan Poltawski added a comment -

        This is related to the navigation changes in 2.4.

        Sam has worked out the problem, so assigning to him

        Show
        Dan Poltawski added a comment - This is related to the navigation changes in 2.4. Sam has worked out the problem, so assigning to him
        Hide
        Sam Hemelryk added a comment -

        Totally accidental.

        That my courses drop down relies on the my courses drop down in the navigation block.
        Prior to 2.4 that would always be populated, however in 2.4 we changed things a bit so that the drop down would be populated by AJAX.
        The renderer used by the moodle.org theme will need to be updated, as will the tutorial I wrote about how to do this http://docs.moodle.org/dev/Themes_2.0_extending_the_custom_menu.

        I'll work on it this arvo, Dan I'll make you integrator for this if thats OK as you'll be able to pull it in and update moodle.org I believe.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Totally accidental. That my courses drop down relies on the my courses drop down in the navigation block. Prior to 2.4 that would always be populated, however in 2.4 we changed things a bit so that the drop down would be populated by AJAX. The renderer used by the moodle.org theme will need to be updated, as will the tutorial I wrote about how to do this http://docs.moodle.org/dev/Themes_2.0_extending_the_custom_menu . I'll work on it this arvo, Dan I'll make you integrator for this if thats OK as you'll be able to pull it in and update moodle.org I believe. Cheers Sam
        Hide
        Sam Hemelryk added a comment -

        Dan,

        I've created a branch that I believe fixes the issue and gets things up and running again.
        Could you please apply it to the moodle.org clone and give it a whirl for me. If you're happy with it then it should be good to go.
        The branch is on the moodle hq repository now and ready to go MDLSITE-2016.

        I should note it functions a little differently to how it did before.
        Previously if you did not have any courses you were actively enrolled in it would show you the courses being displayed under the "Courses" branch in the navigation.
        Now it won't show you anything.
        I decided that it wasn't of great value (most people are logged in anyway right) and it would add complexity and database interaction in order to load a collection of potentially useful courses.

        As for the tutorial I will update that on Monday now.

        Hope thats all ok.

        Many thanks
        Sam

        Show
        Sam Hemelryk added a comment - Dan, I've created a branch that I believe fixes the issue and gets things up and running again. Could you please apply it to the moodle.org clone and give it a whirl for me. If you're happy with it then it should be good to go. The branch is on the moodle hq repository now and ready to go MDLSITE-2016 . I should note it functions a little differently to how it did before. Previously if you did not have any courses you were actively enrolled in it would show you the courses being displayed under the "Courses" branch in the navigation. Now it won't show you anything. I decided that it wasn't of great value (most people are logged in anyway right) and it would add complexity and database interaction in order to load a collection of potentially useful courses. As for the tutorial I will update that on Monday now. Hope thats all ok. Many thanks Sam
        Hide
        Dan Poltawski added a comment -

        Thanks Sam.

        I've tested it and it looks good so i've pulled that into master and also pushed it to moodle.org.

        Only thing I would say is that it might be nice to cache the results.

        Show
        Dan Poltawski added a comment - Thanks Sam. I've tested it and it looks good so i've pulled that into master and also pushed it to moodle.org. Only thing I would say is that it might be nice to cache the results.
        Hide
        Helen Foster added a comment -

        Thanks a lot Sam and Dan - you are both great!

        Show
        Helen Foster added a comment - Thanks a lot Sam and Dan - you are both great!
        Hide
        Joseph Rézeau added a comment -

        Thanks to Sam and Dan.
        I did miss that feature!

        Show
        Joseph Rézeau added a comment - Thanks to Sam and Dan. I did miss that feature!

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development