Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Component/s: moodle.org
    • Labels:
      None

      Description

      As reported by Nicolas Martignoni in https://moodle.org/mod/forum/discuss.php?d=253027:

      1. I'm beginning with this screenshot, showing a problem with some localisations (here, french) and the CSS rule for the "a" element in the forum discussion view.

      CSS rule

      #page-mod-forum-discuss .forumpost .row .topic .author a::after

      has a "display: block;" property, which make the string beginning with a comma very strange. Suppressing this property solves the problem.

      2. Another one. On the forum discussion list, the last column is too tight, which makes the rows too high.

      Adding width: 17%; to the following CSS rule makes it a little better.

      th.header.lastpost

      { width: 17%; }

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Nicolas Martignoni added a comment -

            Thanks Helen for creating this issue.

            Show
            Nicolas Martignoni added a comment - Thanks Helen for creating this issue.
            Hide
            Helen Foster added a comment -

            Just noting that https://moodle.org/news/ also needs fixing - removing 'by' and '-'.

            It would also be good if the fix was suitable for adding to core.

            Show
            Helen Foster added a comment - Just noting that https://moodle.org/news/ also needs fixing - removing 'by' and '-'. It would also be good if the fix was suitable for adding to core.
            Hide
            David Mudrak added a comment -

            This was discussed today at the SITES meeting with a conclusion to make a local hack in the forum code that would simplify the author name and date info (and therefore allowed easier styling of it). Such a hack together with amended LESS/CSS has been deployed for preview to the testing site. Barbara Ramiro please check if you are ok with what I did in the LESS and eventually submit a correction. If you find a minute, we will also need to re-use the same styling for the front page news.

            Nicolas, the situation with the last column of the discussions list is a bit more complex. The HTML code currently produced by the forum module is everything but not suitable for responsive layout of our theme. So we used the similar modifications that we already did for learn.moodle.net and intentionally lowered the importance of additional columns at that page. I know it looks weirdly thin. But the current styling was the result of extensive testing of viewing that page from various devices (mobiles, tablets etc) and it was picked as the lesser of all evils. I would personally not to touch it now any more. We need a new forum, or least improve the HTML it produces.

            Show
            David Mudrak added a comment - This was discussed today at the SITES meeting with a conclusion to make a local hack in the forum code that would simplify the author name and date info (and therefore allowed easier styling of it). Such a hack together with amended LESS/CSS has been deployed for preview to the testing site. Barbara Ramiro please check if you are ok with what I did in the LESS and eventually submit a correction. If you find a minute, we will also need to re-use the same styling for the front page news. Nicolas, the situation with the last column of the discussions list is a bit more complex. The HTML code currently produced by the forum module is everything but not suitable for responsive layout of our theme. So we used the similar modifications that we already did for learn.moodle.net and intentionally lowered the importance of additional columns at that page. I know it looks weirdly thin. But the current styling was the result of extensive testing of viewing that page from various devices (mobiles, tablets etc) and it was picked as the lesser of all evils. I would personally not to touch it now any more. We need a new forum, or least improve the HTML it produces.
            Hide
            David Mudrak added a comment -

            Preview available for testing.

            Show
            David Mudrak added a comment - Preview available for testing.
            Hide
            Barbara Ramiro added a comment -

            Hi David, thanks for working on this. I tested this on forum discussion and found some styles broken. Anyway, fixed it on MDLSITE-2757

            Cheers (" ,)

            Show
            Barbara Ramiro added a comment - Hi David, thanks for working on this. I tested this on forum discussion and found some styles broken. Anyway, fixed it on MDLSITE-2757 Cheers (" ,)
            Hide
            Helen Foster added a comment -

            News forum styling improvement reported as MDLSITE-2759.

            Show
            Helen Foster added a comment - News forum styling improvement reported as MDLSITE-2759 .
            Hide
            Dan Poltawski added a comment -

            We did some hacks on moodle.org core stuff for this, anyone know if they should and were reported upstream?

            Show
            Dan Poltawski added a comment - We did some hacks on moodle.org core stuff for this, anyone know if they should and were reported upstream?

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development