Details

      Description

      Although we moved the log in to the bottom of all pages except the front page to save space for mobile users, it seems from feedback received that everyone would like it back at the top of the page.

        Gliffy Diagrams

        1. logged mockup.png
          36 kB
        2. next1.png
          112 kB
        3. next2.png
          121 kB
        4. next3.png
          184 kB
        5. next4.png
          12 kB
        6. next5.png
          149 kB
        7. study 08 inner header a.jpg
          33 kB

          Activity

          Hide
          mina Nicolas Martignoni added a comment -

          Indeed. Very welcome request.

          Show
          mina Nicolas Martignoni added a comment - Indeed. Very welcome request.
          Hide
          mina Nicolas Martignoni added a comment -

          Theme Aardvark (https://moodle.org/plugins/view.php?plugin=theme_aardvark) shows a possibility for embedding login in the top menu bar.

          Show
          mina Nicolas Martignoni added a comment - Theme Aardvark ( https://moodle.org/plugins/view.php?plugin=theme_aardvark ) shows a possibility for embedding login in the top menu bar.
          Hide
          tsala Helen Foster added a comment -

          As mentioned in a sites meeting, we can save space by removing the text "You are logged in as.." and just have the user's name with the log out button next to it. We also need to make sure that the solution is fine for mobile users.

          Show
          tsala Helen Foster added a comment - As mentioned in a sites meeting, we can save space by removing the text "You are logged in as.." and just have the user's name with the log out button next to it. We also need to make sure that the solution is fine for mobile users.
          Hide
          timhunt Tim Hunt added a comment -

          You could even have just the user's name, and when you click/tap it, you get a menu with options like Log out, Profile, My Moodle, ...

          Actually, at the hackfest, didn't we discuss doing that in core Moodle.

          Show
          timhunt Tim Hunt added a comment - You could even have just the user's name, and when you click/tap it, you get a menu with options like Log out, Profile, My Moodle, ... Actually, at the hackfest, didn't we discuss doing that in core Moodle.
          Hide
          tsala Helen Foster added a comment -

          Thanks Nicolas and Tim for your comments. I think that the Frontend team are planning some improvements in 2.7 similar to what you describe.

          Show
          tsala Helen Foster added a comment - Thanks Nicolas and Tim for your comments. I think that the Frontend team are planning some improvements in 2.7 similar to what you describe.
          Hide
          tsala Helen Foster added a comment -

          When logged in, please could we have the user's name next to the log out button on the front page too. As B. Friesen mentions in MDLSITE-2747, it's a problem not having a link to your profile page on the front page.

          Show
          tsala Helen Foster added a comment - When logged in, please could we have the user's name next to the log out button on the front page too. As B. Friesen mentions in MDLSITE-2747 , it's a problem not having a link to your profile page on the front page.
          Hide
          dbezemer David Bezemer added a comment -

          A temporary triage could be to simply put a contextual login/logout text next to the search icon. Coming from any other page than the frontpage it is now a lot harder to login than it used to be. Especially annoying on the plugins pages.

          Show
          dbezemer David Bezemer added a comment - A temporary triage could be to simply put a contextual login/logout text next to the search icon. Coming from any other page than the frontpage it is now a lot harder to login than it used to be. Especially annoying on the plugins pages.
          Hide
          poltawski Dan Poltawski added a comment - - edited

          Tim Hunt The prototype for that is here: http://prototype.moodle.net/clean/

          Show
          poltawski Dan Poltawski added a comment - - edited Tim Hunt The prototype for that is here: http://prototype.moodle.net/clean/
          Hide
          barbararamiro Barbara Ramiro added a comment -

          Hi David Mudrak, as per our meeting yesterday, attached is the loggedin mockup. Could you write a renderer for that please and i will take care of styling both for desktop and mobile.

          Cheers (" ,)

          Show
          barbararamiro Barbara Ramiro added a comment - Hi David Mudrak , as per our meeting yesterday, attached is the loggedin mockup. Could you write a renderer for that please and i will take care of styling both for desktop and mobile. Cheers (" ,)
          Hide
          mudrd8mz David Mudrak added a comment -

          I'm attaching screenshots made at our staging test server. The login related widgets have been reimplemented in a way that:

          • For logged out users, the "Log in" button appears in the top right corner.
          • For logged-in users, their name is displayed.
          • The name acts as a drop-down toggle link, displaying user-related tools and links, including logout.
          • In the footer of the page, the standard login status is displayed (including the eventual information about logged-in as, switched role, guest access etc).
          Show
          mudrd8mz David Mudrak added a comment - I'm attaching screenshots made at our staging test server. The login related widgets have been reimplemented in a way that: For logged out users, the "Log in" button appears in the top right corner. For logged-in users, their name is displayed. The name acts as a drop-down toggle link, displaying user-related tools and links, including logout. In the footer of the page, the standard login status is displayed (including the eventual information about logged-in as, switched role, guest access etc).
          Hide
          mudrd8mz David Mudrak added a comment -

          Barbara Ramiro I did some cleanup and (hopefully) improvements in the header and page-nav rendering to display both language selector and the login/user menu. Please note that some CSS classes and overall structure we had there is now different (no more "status" class etc). But it should be cleaner now. I put as much as possible into the layout files, should you want to improve the styling yet. I tried to make sure I did not miss any rtl and responsive styling there, but we will need to double check that.

          You may also note a new "mixins.less" file created. The reason for that is that at the front page, the login+language selector (called "usertools" now) are part of the header, while in all other layout files they are part of the page-navbar. So, to be able to share the CSS for both locations, having a mixin seemed to be the best way. Let's see, maybe you will need to redesign the overall structure a bit yet while working on the sticky footer (as you mentioned).

          Show
          mudrd8mz David Mudrak added a comment - Barbara Ramiro I did some cleanup and (hopefully) improvements in the header and page-nav rendering to display both language selector and the login/user menu. Please note that some CSS classes and overall structure we had there is now different (no more "status" class etc). But it should be cleaner now. I put as much as possible into the layout files, should you want to improve the styling yet. I tried to make sure I did not miss any rtl and responsive styling there, but we will need to double check that. You may also note a new "mixins.less" file created. The reason for that is that at the front page, the login+language selector (called "usertools" now) are part of the header, while in all other layout files they are part of the page-navbar. So, to be able to share the CSS for both locations, having a mixin seemed to be the best way. Let's see, maybe you will need to redesign the overall structure a bit yet while working on the sticky footer (as you mentioned).
          Hide
          barbararamiro Barbara Ramiro added a comment -

          Hi David, apparently we were working on slightly similar things yesterday which ended up with quite a bit conflicts. I was working on removing the big logo on columns1_login.php and wondered why we have to have a another layout just for the language dropdown when we could just simply hide it or make conditional statements. Anyway i proceeded with removing the logo but it turned out that it was acting strange and saw some styling which should have been done differently in a proper way and could also be the reason why the sticky footer i was working earlier wasnt perfectly working as i expected so i ended up cleaning it so everything will work no matter what we add to the layout. I committed it last night but didnt push it as I wasnt certain with the real existence of column1_login.php. Anyway, Dan helped me try resolved conflicts but in the end decided to just rework on it based on your changes.

          By the way, thanks for working on the login renderer. I like it so much. Yay!

          Show
          barbararamiro Barbara Ramiro added a comment - Hi David, apparently we were working on slightly similar things yesterday which ended up with quite a bit conflicts. I was working on removing the big logo on columns1_login.php and wondered why we have to have a another layout just for the language dropdown when we could just simply hide it or make conditional statements. Anyway i proceeded with removing the logo but it turned out that it was acting strange and saw some styling which should have been done differently in a proper way and could also be the reason why the sticky footer i was working earlier wasnt perfectly working as i expected so i ended up cleaning it so everything will work no matter what we add to the layout. I committed it last night but didnt push it as I wasnt certain with the real existence of column1_login.php. Anyway, Dan helped me try resolved conflicts but in the end decided to just rework on it based on your changes. By the way, thanks for working on the login renderer. I like it so much. Yay!
          Hide
          barbararamiro Barbara Ramiro added a comment -

          I had a look at mixins.less and i think its not necessary. The header.less applies to all layouts and if there is any exception for the frontpage then it should be specified on frontpage. Thats what i did last night moving frontpage specific styles to frontpage.less as it is not shared with columns1_login.php anymore. Anyway, will sort it now.

          Show
          barbararamiro Barbara Ramiro added a comment - I had a look at mixins.less and i think its not necessary. The header.less applies to all layouts and if there is any exception for the frontpage then it should be specified on frontpage. Thats what i did last night moving frontpage specific styles to frontpage.less as it is not shared with columns1_login.php anymore. Anyway, will sort it now.
          Hide
          tsala Helen Foster added a comment -

          I think the login/user menu looks really great! Thanks David.

          Show
          tsala Helen Foster added a comment - I think the login/user menu looks really great! Thanks David.
          Hide
          timhunt Tim Hunt added a comment -

          Should the name or log-in link be the same size as the text next to it, and base-line aligned?

          Show
          timhunt Tim Hunt added a comment - Should the name or log-in link be the same size as the text next to it, and base-line aligned?
          Hide
          poltawski Dan Poltawski added a comment -

          Lets wait until Barbara gets her hands on it before criticising the CSS, Tim

          Show
          poltawski Dan Poltawski added a comment - Lets wait until Barbara gets her hands on it before criticising the CSS, Tim
          Hide
          mudrd8mz David Mudrak added a comment -

          Positioning of the user menu fixed for RTL languages. Thanks Barbara for other improvements and clean-up in more less files.

          Show
          mudrd8mz David Mudrak added a comment - Positioning of the user menu fixed for RTL languages. Thanks Barbara for other improvements and clean-up in more less files.

            People

            • Votes:
              9 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development