Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-3264

There is nothing wrong with .gitignore files in add-ons

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: moodle.org/plugins
    • Labels:
      None

      Description

      I just tried to upload a new version of pmatchjme, and got told

      Warning It is strongly discouraged for the following files to be present in archive:
      moodleou-moodle-qtype_pmatchjme-0ba4b33/jme/.gitignore
      You may choose the 'Auto remove system files' option below in order to automaticaly remove them from archive (click 'Back' if form is uneditable)

      That is rubbish. It can be a good idea for the same reason that http://git.moodle.org/gw?p=moodle.git;a=blob;f=.gitignore;h=3aced1e2cf96f9b54fabc0af0e1a27835087d7ee;hb=40f0ad21a3fbfaf6e04cc1d53778cf2ca710b8bd#l12 is a good idea.

      qtype_pmatchjme is a good example. For licensing reasons we cannot distribute the contents of the JME folder. Instead we have to ship an empty folder, and tell people to download JME themselves. A .gitingore files is a good way to avoid accidentally committing those files to the repository, and also a good way to make an otherwise empty file.

      So, that validation rule should be removed. Thanks.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: