XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Low Low
    • Integration
    • None

      While i've mentioned that we can't easily link to source without setting up our own gitweb type solution which keeps the commits forever, I forgot about a nice solution we could implement before then with common git hosting sites..

      Worked example with this job:

      1. We know the FETCH_HEAD of the branch we are fetching (in that case its eed599a)
      2. Github provide a way to access source by link: https://github.com/FMCorz/moodle/commit/eed599a/
      3. We know the file and line number, so can link it directly to it.
      4. It doesn't depend on branch name, which would become outdated

      Problems:

      • It will only work while github et al don't git gc the commits, they do do it, so these links won't work forever, but they are better than nothing and it seems it doesn't happen that frequently.
      • Only supports github, I agree we should make these tools git platform agnostic but is just an additional thing and will benefit 99% of our users and we can build it to support any known git repo hosting (Made it support github, bitbucket, gitorious in the end - we can add sites easily if they support web links to provide it)
      • Depends on MDLSITE-3423 so we don't rely on hash of smurf file - no worries, that'll be resolved soon
      • Merging problems might cause line number differences - hopefully not if people rebase - but its possible some auto-merges might slightly upset this
        Cool!

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.