Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-3782

Prechecker jshint check can lead to lots of false positives

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: Integration
    • Labels:
      None

      Description

      While reviewing MDL-48620 for integration i detected that, while shifter was returning no problems (but the rangy one), the jshint execution, at the same time, was returning a bunch of errors (undefined vars...).

      See https://tracker.moodle.org/browse/MDL-48620?focusedCommentId=335713&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-335713 for the comments and discussion about that.

      So that leaded me to create this issue, because I bet we are going to stat producing "false" jshint reports in many situations.

      Not sure if the solution is to switch to shifter, that controls the whole codebase when combining the files, or we must move onto a 2-step way, or perhaps relax checks... or what.

      But it really looks like we need some action here.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                poltawski Dan Poltawski
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Eloy Lafuente (stronk7)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: