Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-4050

Attempted to get rid of core css hack for demo sites. Verdict: Required, kept.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Component/s: sandbox.moodledemo.net
    • Labels:
      None

      Description

      We have this hack in CSS for demo.moodle.net and co:

      commit 8257537da0dd64be58a2a712e1d33abe8fd0691d
      Author: David Mudrák <david@moodle.com>
      Date:   Mon Feb 24 22:25:58 2014 +0100
       
          Make there more space for the sitesbar
      ---
       theme/bootstrapbase/less/moodle.less | 2 +-
       theme/bootstrapbase/style/moodle.css | 2 +-
       2 files changed, 2 insertions(+), 2 deletions(-)
      

      Its only does this:

      diff --git a/theme/bootstrapbase/less/moodle.less b/theme/bootstrapbase/less/moodle.less
      index f608816..c127171 100644
      --- a/theme/bootstrapbase/less/moodle.less
      +++ b/theme/bootstrapbase/less/moodle.less
      @@ -43,7 +43,7 @@
       // Needs to be between bootstrap/bootstrap and
       // bootstrap/responsive.
       body {
      -    padding-top: 60px;
      +    padding-top: 60px + 40px; // Added 40px for our sitebar
       }
       
       // New Moodle stuff that builds on Bootstrap.
      

      But its really annoying because it causes conflicts on every single upgrade due to the less file constantly being rebuilt.

      It would be good to get rid of that less part of the hack. Couldn't we just put the padding change in another stylesheet and avoid having this conflict every time?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Participants:
              Component watchers:
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: