Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-4198

Split current maxcommits hard limit into warning and error

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Low
    • Resolution: Fixed
    • Integration
    • None

    Description

      Right now the remote_branch_checker does accept a maxcommits param about to exit with error if the branch being checked has more than N (default 15) commits. That was created to avoid wrong branches to land by error.

      In practice this has become too strict, because there are continuous valid branches hitting that limit so we recently raised the limit to 100 when invoked by CiBoT from the Tracker. But continues being 15 for individual executions (mdk and friends).

      So, this is about to split that unique hard limit into 2, really parallel to the current branch "age" check we do. One soft limit will lead to a warning, so people will be asked to review the branch is correct. And the hard limit will continue leading to error but can be safely raised to 100 everywhere.

      Both the remote_branch_checker and the bulk_prechecker will allow to reconfigure any of those limits for individual executions if needed.

      That's it, ciao

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: