Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-4400

Favourite plugins report using incorrect record count



    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: moodle.org/plugins
    • Labels:


      As reported by Eoin Campbell in the forums, the "Favourite plugins" report is incorrectly using the number of favourites rather than number of favourited plugins, resulting in two visible issues:

      • ~100 empty pages are added to the "Favourite plugins" report
      • The Overview page lists the number of favourites in parentheses for the "Favourite plugins" report, whereas other reports list the number of plugins.

      The report itself is a clear enough fix - use the correct count (perhaps an appropriate call to $table->set_count_sql(), assuming that it's a table_sql or derivative thereof), so that the paging bar doesn't spit out an ever-growing number of empty pages.

      The overview report is potentially slightly more difficult, as I can understand a desire to show the total number of "favourites" in some way - but as it currently stands, it (as per Eoin's forum post) adds confusion as to the number of plugins. Perhaps it could be tweaked to say "X plugins, favourited Y times" or something along those lines?




            • Votes:
              1 Vote for this issue
              3 Start watching this issue


              • Created: