Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-4424

Problem with CiBot results on MDL-53102 & MDL-52818

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Low
    • Integration
    • None

    Description

      In MDL-52818 I submitted code which came up green, but was actually missing some php docs and should have failed the automated tests.

      Later in MDL-53102 I got a red build because of the missing docs in MDL-52818.

      The way the diffs are performed mis-reports which lines of code should be considered part of each change and I think the fix is as simple as telling the diff in smurf to use the 'patience' algorithm instead of the 'fast' one so that it correctly detects the real function that has been added or changed.

      ie instead of this:

      --- a/lib/tests/moodlelib_test.php
      +++ b/lib/tests/moodlelib_test.php
      @@ -2697,6 +2697,36 @@ class core_moodlelib_testcase extends advanced_testcase {
           }
       
           /**
      +     * Test email MessageID generation
      +     */
      +    public function test_generate_email_messageid() {
      ...
      +    }
      +
      +    /**
            * @dataProvider diverted_emails_provider
            */
           public function test_email_should_be_diverted($divertallemailsto, $divertallemailsexcept, $addresses, $expected) {
      

      it should return this:

      --- a/lib/tests/moodlelib_test.php
      +++ b/lib/tests/moodlelib_test.php
      @@ -2697,6 +2697,36 @@ class core_moodlelib_testcase extends advanced_testcase {
           }
       
      +    /**
      +     * Test email MessageID generation
      +     */
      +    public function test_generate_email_messageid() {
      ...
      +    }
      +
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              brendanheywood Brendan Heywood
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.