Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-5252

Grunt failures in prechecker lead to incorrect links

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: Integration
    • Labels:
      None

      Description

      Whenever a grunt failure happens in the prechecker, the smurf file resulting says "Problems running grunt" together with a link of this type:

      https://github.com/damyon/moodle/blob/66242b95e02796323ee2691c09246b21444b54dc/#L0
      

      The link is wrong because it's pointing to a commit and not to a file... leading to 404 error. Instead we should detect this case and point to the commit in this case (s/blob/commit basically) when a file and line are not available.

      Tip: It's our *prechecker report generator responsibility* to decide about which links are shown... so surely a matter of hacking around there. (link).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Eloy Lafuente (stronk7)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: