Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-5512

Force 'Diff URL' to be built using the actual ancestor

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: Coding style, Integration
    • Labels:
      None

      Description

      It would be nice for:

      1. quick reviews via web
      2. quick access to the actual changes via web, even (and especially!) after the changes have been merged and versioning history will evolve

      to force people to declare the actual commit id in a compare with the Moodle git repo (github for convenience).
      There is no need to keep the forked Moodle branches aligned for the comparison to be in place - it would be better for other contributor workflow reasons.

      The only con I could see is some extra noise by email when the PR is rebased against the new Moodle release branch, which is IMHO a good noise given the pro (including the risk that the contributor will remove the branch from her/his repo in the near future).

      Examples:

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              matteo Matteo Scaramuccia
              Participants:
              Component watchers:
              Marina Glancy, Eloy Lafuente (stronk7), Eloy Lafuente (stronk7)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: