-
Improvement
-
Resolution: Fixed
-
Low
Since 19th June 2020, this rule applies:
- Formal namespaces are required for any new classes in Moodle. The following exceptions apply:
- there is no requirement to move existing non-namespaced classes to a namespace; and
- where an existing mechanism exists for loading a class, and that mechanism does not support the use of a namespaced class, the existing pseudo-namespaced prefix on the class name will be allowed.
- The use of a pseudo-namespace prefix on classnames is deprecated and should only be used in the above situations.
- The use of namespaces must conform to the following rules:
- Classes belonging to a namespace must be created in a classes directory inside a plugin (e.g. mod/forum/classes), or for core code, in lib/classes or subsystemdir/classes.
- The classname and filename for all namespaced classes must conform to the automatic class loading rules. The use of formal PHP namespaces in all new code is required.
Valid examples:
namespace mod_forum;
|
class example { |
}
|
|
|
namespace mod_forum\external;
|
class example { |
}
|
|
namespace core_user;
|
class example { |
}
|
No longer valid:
class mod_forum_example { |
}
|
|
class mod_forum_external_invalid { |
}
|
|
class core_user_example { |
}
|
Background
Our coding style currently states:
Namespaces are not required for any new code and there is no requirement to move non-namespaced classes to namespaces. If namespaces are used - they must conform to these rules.
Classes belonging to a namespace must be created in a classes directory inside a plugin (e.g. mod/forum/classes), or for core code, in lib/classes or subsystemdir/classes.
The classname and filename for all namespaced classes must conform to the automatic class loading rules.
Use at most one namespace declaration per file.
https://docs.moodle.org/dev/Coding_style#Namespaces
Conversely, PSR-1 states:
Code written for PHP 5.3 and after MUST use formal namespaces.
Proposal
I would like to propose the following replacement for this paragraph in our current coding style:
Formal namespaces are required for any new classes in Moodle. The following exceptions apply:
- there is no requirement to move existing non-namespaced classes to a namespace; and
- where an existing mechanism exists for loading a class, and that mechanism does not support the use of a namespaced class, the existing pseudo-namespaced prefix on the class name will be allowed.
The use of a pseudo-namespace prefix on classnames is deprecated and should only be used in the above situations.
The use of namespaces must conform to the following rules:
- Classes belonging to a namespace must be created in a classes directory inside a plugin (e.g. mod/forum/classes), or for core code, in lib/classes or
subsystemdir/classes.- The classname and filename for all namespaced classes must conform to the automatic class loading rules.
Examples
Valid
namespace mod_forum;
|
class example {
|
}
|
|
|
namespace mod_forum\local\example;
|
class foo_bar {
|
}
|
|
|
namespace mod_forum\external;
|
class example {
|
}
|
|
|
namespace core;
|
class example {
|
}
|
|
|
namespace core_user;
|
class example {
|
}
|
No longer valid
class mod_forum_example {
|
}
|
|
|
class mod_forum_external_invalid {
|
}
|
|
|
class core_user_example {
|
}
|
Voting
Two voting options are proposed:
Vote Accept
We should accept the new wording proposed and require the use of formal PHP namespaces in all new code, with the previously accepted caveats.
Vote Reject
We should not make any change to the coding style with regards the use of formal PHP namespaces.
- has a non-specific relationship to
-
CONTRIB-8128 Enforce coding guidelines for requiring namespaces for any new PHP files
-
- Closed
-
- has been marked as being related by
-
-
- Closed
-