Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-6118

Verify that prepare_npm_stuff is always sourced , not executed in sub-shell

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Low
    • Resolution: Unresolved
    • Integration
    • None

    Description

      We need to ensure that the prepare_npm_stuff is always invoked in same shell, because it adjust a number of paths, envs... that the caller needs.

      This is because, since https://github.com/moodlehq/moodle-local_ci/pull/210 we are managing everything from that script using nvm.

      And we had to, quickly, go for https://github.com/moodlehq/moodle-local_ci/pull/212 because we had some uses calling it via sub-shell.

      So this is about to make the prepare_npm_stuff script self-aware and error when not sourced. It seems that can be done: https://stackoverflow.com/a/2684300

      Ciao

      Attachments

        Activity

          People

            Unassigned Unassigned
            stronk7 Eloy Lafuente (stronk7)
            Jun Pataleta, Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: