Uploaded image for project: 'Moodle Community Sites'
  1. Moodle Community Sites
  2. MDLSITE-6196

No ESLint 'source' as used in Mustache check

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: Integration
    • Labels:
      None

      Description

      The Mustache lint check runs ESLint for any JavaScript in the template and reads the messages array in the generated JSON-format report.

      mustache_lint/mustache_lint.php:print_eslint_problems() accesses the source attribute in this report but this is not present in messages (there is a source which is a sibling to messages) resulting in the following in the console output for the CI job (example):

      PHP Notice: Undefined property: stdClass::$source in /var/lib/jenkins/git_repositories/moodle_ci_site/local/ci/mustache_lint/mustache_lint.php on line 233

      ESLint v6.8.0

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            leonstr Leon Stringer
            Participants:
            Component watchers:
            Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: