Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-1245

Controllers instantiated twice with split view

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Others
    • Labels:
    • Testing Instructions:
      Hide
      1. Add a forum to a course.
      2. Add a console.log at the start of mmaModForumDiscussionCtrl.
      3. In the app (tablet display mode), go to course contents and then open the forum. Check that the console.log you added in the previous step is shown only once.
      4. Check that split view is not broken in tablet and phone mode.
      Show
      Add a forum to a course. Add a console.log at the start of mmaModForumDiscussionCtrl. In the app (tablet display mode), go to course contents and then open the forum. Check that the console.log you added in the previous step is shown only once. Check that split view is not broken in tablet and phone mode.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Description

      There's some error with mm-split-view, sometimes the controllers load in the right panel are instantiated twice. I noticed it in forums,it happened most of the times but not 100%.

      Since I can only reproduce it in this case my guess is that it is related to the ui-view name. We have a ui-view="tablet" in course contents, and then we go to a new view that it also has a ui-view="tablet". My guess is that if the subview is loaded too fast then the controller is loaded for both ui-view, so it is instantiated twice.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dpalou Dani Palou
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Juan Leyva
              Tester:
              Juan Leyva
              Participants:
              Component watchers:
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Oct/15