Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-1265

Replace the HEAD request in $mmSitesManager#siteExists with a GET request

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.4
    • 2.4
    • Log in screen
    • Hide
      1. Check that correct URLs are correctly validated (the calls to login/token.php with the fake users does not return invalid HTTP codes) (moodle.org, qa.moodle.net, school.demo.moodle.net) etc..
      2. Use invalid URLS to check that the Cannot connect: Verify that your have typed correctly the URL and your ... message is displayed
      3. Check that the site referenced in the comment restricted to developers is correctly validated
      Show
      Check that correct URLs are correctly validated (the calls to login/token.php with the fake users does not return invalid HTTP codes) (moodle.org, qa.moodle.net, school.demo.moodle.net) etc.. Use invalid URLS to check that the Cannot connect: Verify that your have typed correctly the URL and your ... message is displayed Check that the site referenced in the comment restricted to developers is correctly validated
    • MOODLE_24_STABLE
    • MOODLE_24_STABLE

    Description

      This has been reported a couple of times (for example https://moodle.org/mod/forum/discuss.php?d=321605), we perform a HEAD request to check if a site exists/is valid but sometimes depending on the server configuration (or proxies or firewalls), these types of requests are forbidden and we get 403 errors.

      In order to fix that, we can safely replace the HEAD request with a GET one

      Attachments

        Activity

          People

            jleyva Juan Leyva
            jleyva Juan Leyva
            Dani Palou Dani Palou
            Juan Leyva Juan Leyva
            Juan Leyva Juan Leyva
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              21/Oct/15