[MOBILE-1267] Improve how the Moodle minium version required is checked - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.4
Fix Version/s: 2.4
Component/s: Log in screen
Labels:
- triaged

Testing Instructions:
Hide

Check that you can still add sites with 2.4 or higher version.

Check that you can't add sites with Moodle 2.3 or older.

You can also copy that function to the console (replacing mmCoreWSPrefix with 'local_mobile_') and perform some manual checks.
Show
Check that you can still add sites with 2.4 or higher version. Check that you can't add sites with Moodle 2.3 or older. You can also copy that function to the console (replacing mmCoreWSPrefix with 'local_mobile_') and perform some manual checks.
Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull Master Diff URL:
https://github.com/moodlehq/moodlemobile2/compare/master...dpalou:MOBILE-1267

Description

Currently for checking if the site is using Moodle 2.4 or onwards we check if there is a WS that starts by component_strings (isValidMoodleVersion function)

We are going to remove that WS because it's not currently used, we should rely in the information returned by get_site_info to check the Moodle version (version and release).

Notice that it's possible that sometimes the release or versions values may be empty (not sure if it's a bug in older versions)

Attachments

Activity

People

Assignee:: Dani Palou

Reporter:: Juan Leyva

Peer reviewer:: Juan Leyva

Integrator:: Juan Leyva

Tester:: Juan Leyva

Participants:: Dani Palou, Juan Leyva

Component watchers:

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 17/Oct/15 2:22 AM

Updated:: 10/Feb/17 12:45 AM

Resolved:: 17/Oct/15 4:34 AM

Fix Release Date:: 21/Oct/15