Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-1324

Timemodified calculation is wrong in the new _downloadOrPrefetchPackage

    XMLWordPrintable

Details

    • Hide
      1. Access prototype 29 using the app.
      2. Download the IMSCP in "MoodleMobile Developer Testing Course" > "Different types of resources".
      3. Go back to previous view and go to the "Different types of resources" section. Check that there's no icon shown next to IMSCP (downloaded).
      Show
      Access prototype 29 using the app. Download the IMSCP in "MoodleMobile Developer Testing Course" > "Different types of resources". Go back to previous view and go to the "Different types of resources" section. Check that there's no icon shown next to IMSCP (downloaded).
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE

    Description

      We usually calculate the revision and timemodified of a module using its list of files. In content handlers we use the full list of files (module.contents), that's the right way. In $mmFilepool#_downloadOrPrefetchPackage we don't have the full list, the list of files we're supplying has been filtered to remove the not downloadable files, so the calculation of revision and timemodified can be wrong.

      Also, until now we've always used the FIRST file to calculate the revision and timemodified, maybe we should iterate over all the files and get the highest one.

      Attachments

        Issue Links

          Activity

            People

              dpalou Dani Palou
              dpalou Dani Palou
              Juan Leyva Juan Leyva
              Juan Leyva Juan Leyva
              Juan Leyva Juan Leyva
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.