Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-1462

SCORM: Don't open link in InAppBrowser if it was already prevented

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: SCORM add-on
    • Labels:
    • Testing Instructions:
      1. Add the SCORM in the forum post to a Moodle (see issue description).
      2. Open the SCORM and go to "Démarrer le module" > "Some quiz" > "Enter dans le test...". Check that a modal is shown and no InAppBrowser is opened.
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE

      Description

      Forum post:

      https://moodle.org/mod/forum/discuss.php?d=329774

      We should use event.defaultPrevented to check if a link has already been prevented by another click handler. If so, there's no need for us to open the link in an InAppBrowser.

        Attachments

          Activity

            People

            • Assignee:
              dpalou Dani Palou
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Pau Ferrer
              Integrator:
              Juan Leyva
              Tester:
              Juan Leyva
              Participants:
              Component watchers:
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Apr/16