Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.1.3
-
Fix Version/s: 3.2
-
Component/s: Settings and Preferences
-
Labels:
-
Testing Instructions:
- Click to add a new site. Check that the app asks for the siteurl (no fixed URL set).
- Enter a URL of a site using SSO (e.g. prototype 2.6). Check that a confirm dialog is shown before opening the browser/inappbrowser.
-
Affected Branches:MOODLE_31_STABLE
-
Fixed Branches:MOODLE_32_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
-
Sprint:Moodle Mobile 3.2
Description
There are some settings that the current app is not using but I think we should add them (even if they are empty) so people are aware of them, I'm talking about:
- siteurl: To force a site url in branded apps
- skipssoconfirmation: To skip the SSO confirmation notice
I noticed that siteurl is checked in some places for undefined:
mmCoreConfigConstants.siteurl != 'undefined'