Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-1895

remote addon build process bundles unit test files into addon.js

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.3
    • Fix Version/s: 3.2
    • Component/s: Gulp, Remote addons
    • Labels:
    • Testing Instructions:
      Hide
      1. In the terminal, go to the project root folder and execute this command: 

        gulp remoteaddon -p www/addons/calendar/

      2. Open the folder www/addons/calendar, there should be a file named calendar.zip. Unzip the file.
      3. In the unzipped folder, check that the e2e folder is empty.
      4. Open the file addon.js inside the unzipped folder and check that it doesn't contain the word "describe".
      Show
      In the terminal, go to the project root folder and execute this command: gulp remoteaddon -p www/addons/calendar/ Open the folder www/addons/calendar , there should be a file named calendar.zip . Unzip the file. In the unzipped folder, check that the e2e folder is empty. Open the file addon.js inside the unzipped folder and check that it doesn't contain the word "describe".
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Diff URL:
    • Sprint:
      Moodle Mobile 3.2

      Description

      The gulp step to bundle remote addons grabs .js files from the e2e test folder when creating the addon.js file. The presence of this test code then throws error and prevents installation.

        Attachments

          Issue Links

          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MOBILE-1893 remote addons using directives throw security warnings

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              dpalou Dani Palou
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Pau Ferrer
              Integrator:
              Juan Leyva
              Tester:
              Berta Maroto
              Participants:
              Component watchers:
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Dec/16