Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-2063

Don't invalidate content files in PTR of resources

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. In Moodle web, create a page/book containing both local files and files from external repositories. There is a book already created in Proto 3.3 > Moodle Features Demo > Books.
      2. In the app, access the section and open the page/book so all the files are downloaded.
      3. Now open the Developer tools to be able to inspect the log and network requests. Clear the log and the network requests.
      4. Perform a PTR in the activity. Once it's finished, check in the developer tools that only the external files were downloaded again (in the example from step 1, 2 files: Cigüeña and NBA rule book). There are 2 ways to check it:
        • In the log, search for "$mmWS: Downloading file".
        • In network requests.
      Show
      In Moodle web, create a page/book containing both local files and files from external repositories. There is a book already created in Proto 3.3 > Moodle Features Demo > Books. In the app, access the section and open the page/book so all the files are downloaded. Now open the Developer tools to be able to inspect the log and network requests. Clear the log and the network requests. Perform a PTR in the activity. Once it's finished, check in the developer tools that only the external files were downloaded again (in the example from step 1, 2 files: Cigüeña and NBA rule book). There are 2 ways to check it: In the log, search for "$mmWS: Downloading file". In network requests.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Sprint:
      Moodle Mobile 3.3.0

      Description

      Right now, when we perform a PTR in a resource (mod_resource, page, etc.) we invalidate ALL files, so they have to be downloaded again. Since the user is now able to delete the downloaded files, we shouldn't invalidate those that have a right revision/timemodified. 

      The hard part is to invalidate only some of the files in the resource, since right now all of them have the same component+componentId.

      Also, when a user clicks to synchronize a site we invalidate all the files in the site. Maybe we shouldn't do that.

        Attachments

          Activity

            People

            Assignee:
            dpalou Dani Palou
            Reporter:
            dpalou Dani Palou
            Peer reviewer:
            Pau Ferrer
            Integrator:
            Juan Leyva
            Tester:
            Berta Maroto
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              26/May/17