Moodle Mobile
  1. Moodle Mobile
  2. MOBILE-258

Content page: Labels are not fully displayed (missing html, images, content, etc...)

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: Web
    • Labels:
      None
    • Affected Branches:
      MOODLE_12_STABLE
    • Fixed Branches:
      MOODLE_13_STABLE
    • Rank:
      48225

      Description

      During the last meeting we found out that the label row was a bit odd.
      It would be great that if you clico on it, it expands and show the entire label. Click on it again, it retracts.

      It was also mention that the icon is not needed because it is not displayed in the course format. And the content page is more a course format than a activity chooser/editor (in these dialog/page the label icon is displayed).

        Issue Links

          Activity

          Hide
          Juan Leyva added a comment -

          Hi,
          it seems that we don't get the complete label text from the remote site via webservices, i.e the Film Studies Sort courses:

          {"id":321,"name":"The Administrative Area and Ongoing Course Act...","visible":1,"modicon":"http:\/\/mm.cvaconsulting.com\/moodle\/theme\/image.php\/standard\/label\/1361965098\/icon","modname":"label","modplural":"Labels","indent":0}

          The lib.php get_label_name forces the label lenght to: LABEL_MAX_NAME_LENGTH = 50 so it seems we are missing the label text contents

          Should I open a bug? I think that the get_contents function should handle the special case for labels and adds in the "description" field the full label text

          Regarding the icon, I just deleted it, see commit: https://github.com/moodlehq/moodlemobile/commit/beed3a14e2974fdbde63a7372c2e297fc0e2b037

          Show
          Juan Leyva added a comment - Hi, it seems that we don't get the complete label text from the remote site via webservices, i.e the Film Studies Sort courses: {"id":321,"name":"The Administrative Area and Ongoing Course Act...","visible":1,"modicon":"http:\/\/mm.cvaconsulting.com\/moodle\/theme\/image.php\/standard\/label\/1361965098\/icon","modname":"label","modplural":"Labels","indent":0} The lib.php get_label_name forces the label lenght to: LABEL_MAX_NAME_LENGTH = 50 so it seems we are missing the label text contents Should I open a bug? I think that the get_contents function should handle the special case for labels and adds in the "description" field the full label text Regarding the icon, I just deleted it, see commit: https://github.com/moodlehq/moodlemobile/commit/beed3a14e2974fdbde63a7372c2e297fc0e2b037
          Hide
          Jérôme Mouneyrac added a comment -

          Yes definitively need a MDL for that. Can you write one, I'll work on it.

          Show
          Jérôme Mouneyrac added a comment - Yes definitively need a MDL for that. Can you write one, I'll work on it.
          Hide
          Jérôme Mouneyrac added a comment -

          Once you create the issue you can push this one for 1.3 (Note: it start to have a lot of issue for 1.3 polishing phase ). I'm going to do a app review tomorrow to see what need to be done before 1.2 first release and organize a pre-release meeting here in HQ for next week when Barbara comes back.

          Show
          Jérôme Mouneyrac added a comment - Once you create the issue you can push this one for 1.3 (Note: it start to have a lot of issue for 1.3 polishing phase ). I'm going to do a app review tomorrow to see what need to be done before 1.2 first release and organize a pre-release meeting here in HQ for next week when Barbara comes back.
          Hide
          Juan Leyva added a comment -

          Issue created: See MDL-38440

          Show
          Juan Leyva added a comment - Issue created: See MDL-38440

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development