Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-2636

Support preSets in core-site-plugins-new-content

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.2
    • Fix Version/s: 3.6.0
    • Component/s: Site add-ons
    • Labels:
    • Testing Instructions:
      Hide

      To test this issue you need a site plugin with at least 2 views.

      1. In the template of a site plugin, add a button with the directive core-site-plugins-new-content and [preSets]="{getFromCache: 0, saveToCache: 0}".
      2. In the app, open the plugin. Clear the Network tab and click the button. Check that everytime you click the button, a new WS request is performed (cache isn't used).
      3. Now remove the [preSets], do a PTR and try again. Check that now the request is done only the first time, then it's cached.
      Show
      To test this issue you need a site plugin with at least 2 views. In the template of a site plugin, add a button with the directive core-site-plugins-new-content and  [preSets] ="{getFromCache: 0, saveToCache: 0}". In the app, open the plugin. Clear the Network tab and click the button. Check that everytime you click the button, a new WS request is performed (cache isn't used). Now remove the [preSets] , do a PTR and try again. Check that now the request is done only the first time, then it's cached.
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Sprint:
      Moodle Mobile 3.6.0

      Description

      Most site plugins directives allow passing preSets, we should allow it in this directive too.

        Attachments

          Activity

            People

            Assignee:
            dpalou Dani Palou
            Reporter:
            dpalou Dani Palou
            Peer reviewer:
            Pau Ferrer Pau Ferrer
            Integrator:
            Juan Leyva Juan Leyva
            Tester:
            Albert Gasset Albert Gasset
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jan/19