Some small bugs in the database addon

Field Tab

Scrum

Field Tab

Scrum

Description

While working on https://moodle.atlassian.net/browse/MOBILE-2670#icft=MOBILE-2670 I've found some bugs in the database addon. I've collected all of them on this issue because they are small and I've fixed them at once.

In checkbox and multimenu fields, selected options are not saved except the last one of the list (if it's selected).
Fields cannot be set to an empty value when updating entries (previous value are preserved).
When updating a picture field, the old image is kept (you need to delete the image, save the entry, edit the entry again and upload the new image).
The image of a picture field is displayed broken after updating it.
A required textarea field can be saved with no content using the rich text editor.
URL fields are displayed with the name of the field instead of the URL.
Number fields are always detected as changed, so leaving the form always asks for confirmation even when no change was made.

Testing Instructions

Needed: a database activity with all types of fields except date.

Bug 1

Add an entry and select all the options of the checkbox and multimenu fields.
Save the new entry.
Check that all the options of the checkbox and multimenu fields are listed.

Bug 2

Add an entry with all the fields set to some non-empty value.
Save the new entry and edit it again.
#Set all the fields to empty and save the changes.
Check that the fields of the entry are now blank.

Bug 3 and 4

Add an entry with some image in the picture field.
Delete the picture and upload a different one.
#Save the entry.
Check the new image is displayed.

Bug 5

In web, set the textarea field as required.
In the app, add a new entry (or edit an existing one).
Switch to the rich text editor if it's disabled.
Remove the content of the textarea (if it has any).
Save the entry.
Check that the form is still displayed and below the textarea an error is displayed saying the field is required.

Bug 6

Add an entry with "https://moodle.org" in the URL field.
Save the entry.
Check that the URL is displayed as a link with text "https://moodle.org" .

Bug 7

Add a new entry and leave the number field empty.
Save the changes and edit the added entry.
Without changing any field, click the app back button to leave the form.
Check that the app navigates to the list of entries, no modal is displayed asking for confirmation.

Workaround

None

Activity

Berta Maroto

14 January 2019 at 10:35

Thanks Albert, works as expected.

Test passed

Juan Leyva

7 January 2019 at 10:23

Failing this on behalf of the release testing and Berta feedback

Juan Leyva

19 October 2018 at 14:22

Thanks for working on this issue providing the fixes for the database module, integrated!

Albert Gasset

18 October 2018 at 10:08

Thanks Pau, I've changed the conditional statement.

Pau Ferrer

18 October 2018 at 09:31

Thank you @Albert Gasset for working on this issue!

Your code seems good, but I spotted some minor thinks you may want to review:

I think you could use an inline conditional statement (question mark operator) since it's much more efficient. Here.

Feel free to submit it to integration when done.

Resize work item view side panel

Fixed

Details

Assignee

Albert Gasset

Reporter

Albert Gasset

Labels

triaged

Peer reviewer

Pau Ferrer

Tester

Berta Maroto

Pull from Repository

Pull Main Branch

MOBILE-2693

Pull Main Diff URL

Priority

Minor

Clockify

Created 17 October 2018 at 11:12

Updated 14 January 2019 at 10:40

Resolved 14 January 2019 at 10:40

Some small bugs in the database addon

Description

Testing Instructions

Workaround

Activity

Details

Assignee

Reporter

Labels

Peer reviewer

Tester

Pull from Repository

Pull Main Branch

Pull Main Diff URL

Components

Fix versions

Affects versions

Priority

Clockify