Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-2719

Stop sending fake credentials to check if the site exists

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.2
    • Fix Version/s: 3.6.0
    • Component/s: Authentication
    • Labels:
    • Sprint:
      Moodle Mobile 3.6.0

      Description

      We were sending fake credentials because of MDL-52902 (CORS check was after the credentials check), but since the fix was integrated for 3.1 and we now support only 3.1 we can stop sending the parameters and it should work the same. But instead getting an invalid username error we'll get a missing parameter one.

      This will prevent logs to be filled with unsuccessful login attempts

      Note, this was only happening for the web app version (not in the app or desktop)

        Attachments

          Activity

            People

            Assignee:
            dpalou Dani Palou
            Reporter:
            jleyva Juan Leyva
            Peer reviewer:
            Pau Ferrer
            Integrator:
            Juan Leyva
            Tester:
            Albert Gasset
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jan/19