Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-2752

Target is ignored when redefining window.open inside an iframe

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.2
    • Fix Version/s: 3.6.0
    • Component/s: SCORM add-on
    • Labels:
    • Testing Instructions:
      Hide
      1. Login in mobile 34 as a student.
      2. Open Course with SCORMs > SVG NON-SCALABLE > Informationssicherheit_Gerald
      3. Play the SCORM and, once it is loaded, go back to the entry page. Check that no error is displayed (it used to display an error saying that file could not be opened because it had no extension).
      Show
      Login in mobile 34 as a student. Open Course with SCORMs > SVG NON-SCALABLE > Informationssicherheit_Gerald Play the SCORM and, once it is loaded, go back to the entry page. Check that no error is displayed (it used to display an error saying that file could not be opened because it had no extension).
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull Master Diff URL:
    • Sprint:
      Moodle Mobile 3.6.0

      Description

      We treat the target when a user clicks in a link inside an iframe, but we ignore the target when redefining window.open.

      The code is in here:

      https://github.com/moodlehq/moodlemobile2/blob/master/src/providers/utils/iframe.ts#L93

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jan/19