Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-2960

Improve Vimeo embedding for 3.7 onwards

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.6.1
    • Fix Version/s: 3.7.0
    • Component/s: Others
    • Labels:
    • Testing Instructions:
      Hide

      3.7 site & phone

      1. On a phone with a small screen (an iPhone 5, for example), log in to mobilemaster.moodledemo.net
      2. Go to MoodleMobile Developer Testing Course > Resource: Page > Vimeo Video
      3. Check that all videos adapt to the width of the screen.

      3.7 site & tablet

      1. On a tablet, log in to mobilemaster.moodledemo.net
      2. Go to MoodleMobile Developer Testing Course > Resource: Page > Vimeo Video
      3. Check that all the videos except the last 2 don't adapt to the width of the screen, they are smaller. The last 2 videos adapt to the full width of the screen.

      3.6 or older site & phone

      1. On a phone with a small screen (an iPhone 5, for example), log in to mobile34.next.moodle.com
      2. Go to MoodleMobile Developer Testing Course > Resource: Page > Vimeo Video
      3. Check that all the videos are displayed, although they don't adapt to the width of the screen, they are bigger.

       

      Show
      3.7 site & phone On a phone with a small screen (an iPhone 5, for example), log in to mobilemaster.moodledemo.net Go to MoodleMobile Developer Testing Course > Resource: Page > Vimeo Video Check that all videos adapt to the width of the screen. 3.7 site & tablet On a tablet, log in to mobilemaster.moodledemo.net Go to MoodleMobile Developer Testing Course > Resource: Page > Vimeo Video Check that all the videos except the last 2 don't adapt to the width of the screen, they are smaller. The last 2 videos adapt to the full width of the screen. 3.6 or older site & phone On a phone with a small screen (an iPhone 5, for example), log in to mobile34.next.moodle.com Go to MoodleMobile Developer Testing Course > Resource: Page > Vimeo Video Check that all the videos are displayed, although they don't adapt to the width of the screen, they are bigger.  
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
    • Sprint:
      Moodle App 3.7.0

      Description

      Thanks to MDL-65255 we can improve how Vimeo videos will be embedded because we won't have to pass the width and height anymore to the script embedding them.

      See https://mobile34.next.moodle.com/mod/page/view.php?id=32&forceview=1 for some examples that must be tested

        Attachments

          Issue Links

          is blocked by

          Improvement - An enhancement to an existing Moodle feature. MDL-65255 Vimeo script (for frame embedding) should not require width and height

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              albert.gasset Albert Gasset
              Reporter:
              jleyva Juan Leyva
              Peer reviewer:
              Dani Palou Dani Palou
              Integrator:
              Juan Leyva Juan Leyva
              Tester:
              Isabel Renedo Rouco Isabel Renedo Rouco
              Participants:
              Component watchers:
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                7/Jun/19