Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3001

Retrieving the course users details has a big impact on performance

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.7.0
    • Fix Version/s: 3.7.0
    • Component/s: Offline
    • Labels:
    • Testing Instructions:
      Hide

      This issue only needs to be tested in 1 OS. You will have to use the DevTools to inspect Network requests.

      1. Install the app in the device and login as a teacher in master site.
      2. Go to MM Dev Course > Forum and enable download options.
      3. Open the Dev Tools and clear the network requests.
      4. Download a forum with ratings enabled. Check that there are no WS requests to user profile or ratings.
      5. Once done, go offline and open the forum. Check that you can see the user's avatars.
      6. Try to view the list of ratings of a forum post (clicking the average of ratings). Check that you get a connection error.
      7. Now go the Glossary section.
      8. Go online, clear network requests and download the glossary "Glossary (browseable by author and date)". Check that there are no WS requests to user profile or ratings.
      9. Once done, go offline and open the glossary. Check that you can see the user's avatars (e.g. in the "New 3.6.1" entry).
      10. Now go to the Feedback section.
      11. Go online, clear network requests and download the feedback "Not-anonymous feedback with multiple attempts numbered questions". Check that there are no WS requests to user profile.
      12. Once done, go offline, open the feedback and go to "Show non-respondents". Check that you can see the names of the users, but not their avatar (it's the default image).
      13. Now go to the dattabase section.
      14. Go online, clear network requests and download a database with ratings enabled. Check that there are no WS requests to ratings.
      Show
      This issue only needs to be tested in 1 OS. You will have to use the DevTools to inspect Network requests. Install the app in the device and login as a teacher in master site. Go to MM Dev Course > Forum and enable download options. Open the Dev Tools and clear the network requests. Download a forum with ratings enabled. Check that there are no WS requests to user profile or ratings. Once done, go offline and open the forum. Check that you can see the user's avatars. Try to view the list of ratings of a forum post (clicking the average of ratings). Check that you get a connection error. Now go the Glossary section. Go online, clear network requests and download the glossary "Glossary (browseable by author and date)". Check that there are no WS requests to user profile or ratings. Once done, go offline and open the glossary. Check that you can see the user's avatars (e.g. in the "New 3.6.1" entry). Now go to the Feedback section. Go online, clear network requests and download the feedback "Not-anonymous feedback with multiple attempts numbered questions". Check that there are no WS requests to user profile. Once done, go offline, open the feedback and go to "Show non-respondents". Check that you can see the names of the users, but not their avatar (it's the default image). Now go to the dattabase section. Go online, clear network requests and download a database with ratings enabled. Check that there are no WS requests to ratings.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Sprint:
      Moodle App 3.7.0

      Description

      When downloading a course for offline we are retrieving the complete user details doing a request per profile, this should be improved and get all the user profiles in just one single request (maybe just once, when downloading the course and depending on the number of participants?)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dpalou Daniel Palou
                Reporter:
                jleyva Juan Leyva
                Peer reviewer:
                Pau Ferrer
                Integrator:
                Juan Leyva
                Tester:
                Juan Leyva
                Participants:
                Component watchers:
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  7/Jun/19