Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3064

core_course_check_updates is called several times with a different list on prefetch

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This issue only needs to be tested in 1 device.

      In this issue you will download sections and courses and you'll have to inspect the network requests, so I suggest you to download small courses.

      1. Login in a 3.2+ site (it can be a master site) and open a course.
      2. Enable downloads in the course.
      3. Open the inspector and clear all network requests.
      4. Click to download a section. If a confirm is shown, clear network requests and confirm the download.
      5. Once the download finishes, check that the section icon changes to the right icon.
      6. In network requests, check that there's no request to core_course_check_updates after the download (there could be some BEFORE the download, and they should always have the same list of modules).
      7. Now select "All sections" using the section selector.
      8. Open the inspector and clear all network requests.
      9. Click to download the section "All sections". If a confirm is shown, clear network requests and confirm the download.
      10. Once the download finishes, check that all the sections icons change to the right icon.
      11. In network requests, check that there's no request to core_course_check_updates during or after the download (there could be some at the start of the download, and they should always have the same list of modules).
      12. Now go to App Settings > Space usage and clear all the data from the current site.
      13. Go to dashboard.
      14. Open the inspector and clear all network requests.
      15. Click to download a course. If a confirm is shown, clear network requests and confirm the download.
      16. Once the download finishes, check that there's no request to core_course_check_updates during or after the download (there could be some at the start of the download, and they should always have the same list of modules).
      Show
      This issue only needs to be tested in 1 device. In this issue you will download sections and courses and you'll have to inspect the network requests, so I suggest you to download small courses. Login in a 3.2+ site (it can be a master site) and open a course. Enable downloads in the course. Open the inspector and clear all network requests. Click to download a section. If a confirm is shown, clear network requests and confirm the download. Once the download finishes, check that the section icon changes to the right icon. In network requests, check that there's no request to  core_course_check_updates after the download (there could be some BEFORE the download, and they should always have the same list of modules). Now select "All sections" using the section selector. Open the inspector and clear all network requests. Click to download the section "All sections". If a confirm is shown, clear network requests and confirm the download. Once the download finishes, check that all the sections icons change to the right icon. In network requests, check that there's no request to  core_course_check_updates  during or after the download (there could be some at the start of the download, and they should always have the same list of modules). Now go to App Settings > Space usage and clear all the data from the current site. Go to dashboard. Open the inspector and clear all network requests. Click to download a course. If a confirm is shown, clear network requests and confirm the download. Once the download finishes, check that there's no request to  core_course_check_updates  during or after the download (there could be some at the start of the download, and they should always have the same list of modules).
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Sprint:
      Moodle App 3.7.1

      Description

      Noticed by Juan when downloading the "Psychology in cinema" course from school demo. The course wasn't downloaded before.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  30/Aug/19