Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3112

Copy all params from otherdata if useOtherData is not undefined or array

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This issue should be tested only in 1 device.

      1. Install the plugin attached to this issue in a Moodle site, in the local folder.
      2. In the app, login in that site and open a course. Check that you see an option "My awesome plugin" at the top.
      3. Open that option. Check you see a list of "args" and 3 buttons. Check the list of args doesn't contain any param named "first" or "second".
      4. Click the button "No otherdata added". Check that the new page doesn't contain any param named "first" or "second" either.
      5. Now click the button "All otherdata added". Check that the new page contains a param named "first" and another called "second".
      6. Now click the button "Only first value". Check that the new page contains a param named "first" but not the one called "second".

       

      Show
      This issue should be tested only in 1 device. Install the plugin attached to this issue in a Moodle site, in the local folder. In the app, login in that site and open a course. Check that you see an option "My awesome plugin" at the top. Open that option. Check you see a list of "args" and 3 buttons. Check the list of args doesn't contain any param named "first" or "second". Click the button "No otherdata added". Check that the new page doesn't contain any param named "first" or "second" either. Now click the button "All otherdata added". Check that the new page contains a param named "first" and another called "second". Now click the button "Only first value". Check that the new page contains a param named "first" but not the one called "second".  
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Sprint:
      Moodle App 3.7.1

      Description

      Right now, to copy all the params from otherdata you need to set it to false, null or ''. This can be a bit confusing because [useOtherData]="false" seems like you don't want to use otherdata at all.

      We cannot change this because it would break existing plugins, but we can let it accept more values like "true". 

        Attachments

          Activity

            People

            • Assignee:
              dpalou Dani Palou
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Pau Ferrer
              Integrator:
              Juan Leyva
              Tester:
              Pau Ferrer
              Participants:
              Component watchers:
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                30/Aug/19