Uploaded image for project: 'Moodle app'
  1. Moodle app
  2. MOBILE-3132

Call fillContextMenu even if there's an error

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Waiting for testing
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.7.1
    • Fix Version/s: None
    • Component/s: Course contents add-on
    • Labels:
    • Testing Instructions:
      Hide

      This issue only needs to be tested in 1 device.

      1. Add a new site in the app.
      2. Open a course.
      3. Without downloading anything, go offline.
      4. Open any resource or activity. Check that you get the error: "There was a problem connecting..."
      5. Open the context menu. Check that you see a "Download" option.
      6. You can repeat this test with any resource or activity, all of them should show the Download option after an error.
      Show
      This issue only needs to be tested in 1 device. Add a new site in the app. Open a course. Without downloading anything, go offline. Open any resource or activity. Check that you get the error: "There was a problem connecting..." Open the context menu. Check that you see a "Download" option. You can repeat this test with any resource or activity, all of them should show the Download option after an error.
    • Affected Branches:
      MOODLE_37_STABLE
    • Sprint:
      Moodle App 3.8.0

      Description

      Right now, in all activities we only call fillContextMenu if all the data is fetched correctly. This function is the one that displays the download and space usage options inside an activity.

      In feedback we detected the following case: if the feedback uses separate groups and the student doesn't belong to any group, he can view and answer the feedback but, after answering, he'll get an error saying he doesn't belong to any group. This means the user can view the download & space usage options at first, but after answering he won't be able to see them anymore. This didn't make much sense, so we changed it so fillContextMenu is always called.

      For coherence, we should do the same in all activities.

        Attachments

          Activity

            People

            • Assignee:
              dpalou Dani Palou
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Pau Ferrer
              Integrator:
              Juan Leyva
              Tester:
              Isabel Renedo Rouco
              Participants:
              Component watchers:
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: